Small rmpyc improvement - make it safe for paths containing spaces

forum/forms/qanda.py

@@ -5,6 +5,7 @@
 from django.utils.translation import ugettext as _
 
 from django.utils.encoding import smart_unicode
+from django.utils.safestring import mark_safe
 from general import NextUrlField, UserNameField
 
 from forum import settings
@@ -71,7 +72,7 @@ def clean(self, value):
 
 
 class TagNamesField(forms.CharField):
-    def __init__(self, user=None, *args, **kwargs):
+    def __init__(self, user=None, initial='', *args, **kwargs):
         super(TagNamesField, self).__init__(*args, **kwargs)
 
         self.required = True
@@ -82,7 +83,7 @@ def __init__(self, user=None, *args, **kwargs):
         self.help_text = _('Tags are short keywords, with no spaces within. At least %(min)s and up to %(max)s tags can be used.') % {
             'min': settings.FORM_MIN_NUMBER_OF_TAGS, 'max': settings.FORM_MAX_NUMBER_OF_TAGS    
         }
-        self.initial = ''
+        self.initial = initial
         self.user = user
 
     def clean(self, value):
@@ -95,6 +96,16 @@ def clean(self, value):
         list = {}
         for tag in split_re.split(data):
             list[tag] = tag
+
+        if settings.ENFORCE_TAG_FORMAT_FLAG and settings.ENFORCE_TAG_FORMAT_RX and len(str(settings.ENFORCE_TAG_FORMAT_RX.strip())) > 0:
+            try:
+                regexp = re.compile(str(settings.ENFORCE_TAG_FORMAT_RX.strip()))
+                good_tags = [tag for tag in list.values() if regexp.match(tag)]
+                if len(good_tags) == 0:
+                    raise forms.ValidationError(mark_safe(_(settings.ENFORCE_TAG_FORMAT_ERROR_MESSAGE)))
+            except re.error:
+                logging.error("Error while trying to match tags against '%s'" % settings.ENFORCE_TAG_FORMAT_RX)
+                pass
 
         if len(list) > settings.FORM_MAX_NUMBER_OF_TAGS or len(list) < settings.FORM_MIN_NUMBER_OF_TAGS:
             raise forms.ValidationError(_('please use between %(min)s and %(max)s tags') % { 'min': settings.FORM_MIN_NUMBER_OF_TAGS, 'max': settings.FORM_MAX_NUMBER_OF_TAGS})
@@ -175,10 +186,10 @@ class AskForm(forms.Form):
     title  = TitleField()
     text   = QuestionEditorField()
 
-    def __init__(self, data=None, user=None, *args, **kwargs):
+    def __init__(self, data=None, user=None, default_tag='', *args, **kwargs):
         super(AskForm, self).__init__(data, *args, **kwargs)
 
-        self.fields['tags']   = TagNamesField(user)
+        self.fields['tags']   = TagNamesField(user, initial=default_tag)
 
         if int(user.reputation) < settings.CAPTCHA_IF_REP_LESS_THAN and not (user.is_superuser or user.is_staff):
             spam_fields = call_all_handlers('create_anti_spam_field')

forum/markdownext/mdx_nofollow.py

@@ -0,0 +1,18 @@
+import markdown
+import re
+
+R_NOFOLLOW = re.compile('<a ')
+S_NOFOLLOW = '<a rel="nofollow" '
+
+class NofollowPostprocessor(markdown.postprocessors.Postprocessor):
+    def run(self, text):
+        return R_NOFOLLOW.sub(S_NOFOLLOW, text)
+
+class NofollowExtension(markdown.Extension):
+    """ Add nofollow for links to Markdown. """
+
+    def extendMarkdown(self, md, md_globals):
+        md.postprocessors.add('nofollow', NofollowPostprocessor(md), '_end')
+
+def makeExtension(configs={}):
+    return NofollowExtension(configs=configs)

forum/markdownext/mdx_settingsparser.py

@@ -1,4 +1,8 @@
-from os import linesep
+try:
+    from os import linesep
+except ImportError:
+    linesep = "\n"
+
 from csv import reader, QUOTE_NONE
 import markdown
 from markdown import Extension

forum/models/node.py

@@ -11,7 +11,7 @@
 from django.utils.html import strip_tags
 from forum.utils.html import sanitize_html
 from forum.utils.userlinking import auto_user_link
-from forum.settings import SUMMARY_LENGTH
+from forum.settings import SUMMARY_LENGTH, USE_NOFOLLOW_ON_USER_LINKS
 from utils import PickledObjectField
 
 class NodeContent(models.Model):
@@ -29,7 +29,8 @@ def html(self):
         return self.body
 
     def rendered(self, content):
-        return auto_user_link(self, self._as_markdown(content, *['auto_linker']))
+        extensions = ['auto_linker', 'nofollow'] if USE_NOFOLLOW_ON_USER_LINKS else ['auto_linker']
+        return auto_user_link(self, self._as_markdown(content, *extensions))
 
     @classmethod
     def _as_markdown(cls, content, *extensions):

forum/settings/form.py

@@ -1,5 +1,5 @@
-import os.path
 from base import Setting, SettingSet
+from django.forms.widgets import Textarea
 from django.utils.translation import ugettext_lazy as _
 
 FORUM_SET = SettingSet('form', _('Form settings'), _("General settings for the OSQA forms."), 10)
@@ -14,6 +14,21 @@
 help_text = _("Limit tag creation to super users, staff or users with a minimum reputation."),
 required=False))
 
+ENFORCE_TAG_FORMAT_FLAG = Setting('ENFORCE_TAG_FORMAT_FLAG', False, FORUM_SET, dict(
+label = _("Enforce tag format"),
+help_text = _("Should question's tags be checked against a regular expression"),
+required=False))
+
+ENFORCE_TAG_FORMAT_RX = Setting('ENFORCE_TAG_FORMAT_RX', '', FORUM_SET, dict(
+label = _("Enforce tag format RX"),
+help_text = _("Regular eXpression which must match at least one tag on the question"),
+required=False))
+
+ENFORCE_TAG_FORMAT_ERROR_MESSAGE = Setting('ENFORCE_TAG_FORMAT_ERROR_MESSAGE', '', FORUM_SET, dict(
+label = _("Enforce tag format error message"),
+help_text = _("Error message to show if the tags from a question fail to meet the above regular expression (can contain HTML)"),
+widget=Textarea(attrs={'rows': '10'}),
+required=False)) 
 
 """ settings for questions """
 FORM_MIN_QUESTION_TITLE = Setting('FORM_MIN_QUESTION_TITLE', 10, FORUM_SET, dict(

forum/settings/static.py

@@ -103,4 +103,9 @@
         label = _("Custom Head"),
         help_text = _("Your custom Head elements."),
         widget=Textarea(attrs={'rows': '25'}),
-        required=False))
+        required=False))
+
+MATHJAX_ENABLED = Setting('MATHJAX_ENABLED', False, HEAD_SET, dict(
+    label = _("Enable LaTeX support"),
+    help_text = _("Enable LaTeX support via MathJax, by loading MathJax javascript"),
+    required=False))

forum/settings/users.py

@@ -48,6 +48,11 @@
 help_text = _("If you check this the user accept rate will be displayed on the user posts."),
 required=False))
 
+USE_USERS_QUESTIONS_FOR_ACCEPT_RATE = Setting('USE_USERS_QUESTIONS_FOR_ACCEPT_RATE', True, USERS_SET, dict(
+label = _("Calculate accept rate SO style"),
+help_text = _("Calculate rate as own questions with accepted answers / own questions"),
+required=False))
+
 FREEZE_ACCEPT_RATE_FOR = Setting('FREEZE_ACCEPT_RATE_FOR',
 ["admin",],
 USERS_SET, dict(

forum/settings/view.py

@@ -57,3 +57,10 @@
 label = _("Limit related tags block"),
 help_text = _("Limit related tags block size in questions list pages. Set to 0 to display all all tags.")))
 
+AUTO_SET_TAG_ON_QUESTION = Setting('AUTO_SET_TAG_ON_QUESTION', False, VIEW_SET, dict(
+label = _("Automatically set tag on questions asked from tag page"), required=False,
+help_text = _("Automatically set the tag on new questions asked from the tag page")))
+
+USE_NOFOLLOW_ON_USER_LINKS = Setting('USE_NOFOLLOW_ON_USER_LINKS', False, VIEW_SET, dict(
+label = _("Set nofollow on links in questions/answers"), required=False,
+help_text = _("Set the nofollow attribute on links in questions/answers (only applies for new/edited questions/answers)")))

forum/skins/default/media/js.src/pagedown/Markdown-combo.js

@@ -2269,6 +2269,7 @@ else
             elapsedTime = currTime - prevTime;
 
             pushPreviewHtml(text);
+            if (MathJax) { MathJax.Hub.Queue(["Typeset",MathJax.Hub]); }
         };
 
         // setTimeout is already used.  Used as an event listener.

forum/skins/default/media/js.src/pagedown/Markdown.Editor.js

@@ -829,6 +829,7 @@
             elapsedTime = currTime - prevTime;
 
             pushPreviewHtml(text);
+            if (MathJax) { MathJax.Hub.Queue(["Typeset",MathJax.Hub]); }
         };
 
         // setTimeout is already used.  Used as an event listener.