Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSQA-823 - Show question list even for non-existing tags & prepopulate tags field for new questions #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdman
Copy link

@cdman cdman commented Mar 15, 2012

Add two new features:

  • show (empty) question list even for non-existing tags (with a 418 return code to prevent indexing them)
  • when the "ask question" link is clicked from a tag page the new question is prepopulated with the given tag

These features are useful when the OSQA instance is linked from an other site with some automatically generated tags (like "chapter1", "chapter2", ...).

@DanielThomas
Copy link
Owner

Nice idea, have no problem merging to my branch given it's configurable and I think I could actually do with this feature. As much I'm a fan of RFC 2324, that's not the correct way to prevent a page being indexed, you want a 200 to go to the browser. Can you change it to something standard please?

https://developers.google.com/webmasters/control-crawl-index/docs/robots_meta_tag

@cdman
Copy link
Author

cdman commented Mar 24, 2012

The current implementation returns the (customized) 404 page when a non-existing tag is requested. Ideally I would like to return a customized 404 page in this case, however (being a Python / Django n00b) I couldn't find a way to override the default 404 template.

In my opinion a custom error page is more in the spirit of the original implementation, is simpler to implement (doesn't depend on the templates containing a particular code) and ensures that most HTTP tools stop the processing of the page, not just well-written robots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants