Merge pull request #9 from Daniel-Ric/feature/2026-01-28/analyze-and-fix-empty-top-creators-response

fix-mc-creators

Author: Daniel-Ric

src/routes/inventory.routes.js

@@ -1,10 +1,9 @@
 import express from "express";
 import Joi from "joi";
-import jwtLib from "jsonwebtoken";
 import {jwtMiddleware} from "../utils/jwt.js";
 import {asyncHandler} from "../utils/async.js";
 import {getEntityToken, getPlayFabInventory, loginWithXbox} from "../services/playfab.service.js";
-import {getMCBalances, getMCInventory} from "../services/minecraft.service.js";
+import {extractReceiptEntitlements, getMCBalances, getMCInventory} from "../services/minecraft.service.js";
 import {badRequest} from "../utils/httpError.js";
 
 const router = express.Router();
@@ -236,21 +235,17 @@ router.get("/minecraft/creators/top", jwtMiddleware, asyncHandler(async (req, re
 
     const counts = {};
     for (const e of (ents || [])) {
-        const rawReceipt = e?.Receipt ?? e?.receipt ?? null;
-        if (typeof rawReceipt !== "string" || !rawReceipt) continue;
-
-        let decoded;
-        try {
-            decoded = jwtLib.decode(rawReceipt);
-        } catch {
+        const directCreator = e?.creatorId ?? e?.CreatorId ?? e?.creatorID ?? null;
+        if (directCreator) {
+            counts[directCreator] = (counts[directCreator] || 0) + 1;
             continue;
         }
-
-        const recEnts = decoded?.Receipt?.Entitlements;
+        const rawReceipt = e?.Receipt ?? e?.receipt ?? null;
+        const recEnts = extractReceiptEntitlements(rawReceipt);
         if (!Array.isArray(recEnts)) continue;
 
         for (const re of recEnts) {
-            const cid = re?.CreatorId ?? re?.creatorId ?? null;
+            const cid = re?.CreatorId ?? re?.creatorId ?? re?.creatorID ?? null;
             if (!cid) continue;
             counts[cid] = (counts[cid] || 0) + 1;
         }

src/services/minecraft.service.js

@@ -1,4 +1,5 @@
 import {randomUUID} from "crypto";
+import jwtLib from "jsonwebtoken";
 
 import {env} from "../config/env.js";
 import {badRequest, forbidden, internal, unauthorized} from "../utils/httpError.js";
@@ -91,6 +92,43 @@ export async function getMCInventory(mcToken, includeReceipt = false) {
     }
 }
 
+export function extractReceiptEntitlements(rawReceipt) {
+    if (!rawReceipt) return null;
+    if (typeof rawReceipt === "string") {
+        const trimmed = rawReceipt.trim();
+        if (!trimmed) return null;
+        if (trimmed.startsWith("{") || trimmed.startsWith("[")) {
+            try {
+                const parsed = JSON.parse(trimmed);
+                return parsed?.Receipt?.Entitlements || parsed?.receipt?.entitlements || parsed?.entitlements || null;
+            } catch {
+                return null;
+            }
+        }
+        let decoded = null;
+        try {
+            decoded = jwtLib.decode(trimmed);
+        } catch {
+            decoded = null;
+        }
+        const decodedEnts = decoded?.Receipt?.Entitlements || decoded?.receipt?.entitlements || decoded?.entitlements || null;
+        if (Array.isArray(decodedEnts)) return decodedEnts;
+        if (!trimmed.includes(".")) {
+            try {
+                const parsed = JSON.parse(Buffer.from(trimmed, "base64").toString("utf8"));
+                return parsed?.Receipt?.Entitlements || parsed?.receipt?.entitlements || parsed?.entitlements || null;
+            } catch {
+                return null;
+            }
+        }
+        return null;
+    }
+    if (typeof rawReceipt === "object") {
+        return rawReceipt?.Receipt?.Entitlements || rawReceipt?.receipt?.entitlements || rawReceipt?.entitlements || null;
+    }
+    return null;
+}
+
 export async function getMCBalances(mcToken) {
     if (!mcToken) throw badRequest("mcToken missing");
     try {

tests/messaging.test.js

@@ -1,7 +1,8 @@
 import test from "node:test";
 import assert from "node:assert/strict";
 
-import {buildMarketplaceMessageEventsPayload, buildMarketplaceMessagingPayload} from "../src/services/minecraft.service.js";
+import jwtLib from "jsonwebtoken";
+import {buildMarketplaceMessageEventsPayload, buildMarketplaceMessagingPayload, extractReceiptEntitlements} from "../src/services/minecraft.service.js";
 
 test("buildMarketplaceMessagingPayload uses defaults", () => {
     const {payload, sessionId} = buildMarketplaceMessagingPayload({});
@@ -72,3 +73,29 @@ test("buildMarketplaceMessageEventsPayload builds multiple events", () => {
         eventDateTime: "2026-01-21T10:14:44.051Z"
     }]);
 });
+
+test("extractReceiptEntitlements reads jwt receipt entitlements", () => {
+    const receiptPayload = {Receipt: {Entitlements: [{CreatorId: "creator-1"}]}};
+    const token = jwtLib.sign(receiptPayload, "secret");
+    const ents = extractReceiptEntitlements(token);
+    assert.deepEqual(ents, receiptPayload.Receipt.Entitlements);
+});
+
+test("extractReceiptEntitlements reads json receipt entitlements", () => {
+    const receiptPayload = {Receipt: {Entitlements: [{CreatorId: "creator-2"}]}};
+    const ents = extractReceiptEntitlements(JSON.stringify(receiptPayload));
+    assert.deepEqual(ents, receiptPayload.Receipt.Entitlements);
+});
+
+test("extractReceiptEntitlements reads base64 receipt entitlements", () => {
+    const receiptPayload = {Receipt: {Entitlements: [{CreatorId: "creator-3"}]}};
+    const encoded = Buffer.from(JSON.stringify(receiptPayload), "utf8").toString("base64");
+    const ents = extractReceiptEntitlements(encoded);
+    assert.deepEqual(ents, receiptPayload.Receipt.Entitlements);
+});
+
+test("extractReceiptEntitlements reads object receipt entitlements", () => {
+    const receiptPayload = {Receipt: {Entitlements: [{CreatorId: "creator-4"}]}};
+    const ents = extractReceiptEntitlements(receiptPayload);
+    assert.deepEqual(ents, receiptPayload.Receipt.Entitlements);
+});