Skip to content

Commit beeba97

Browse files
authored
Merge pull request #56 from DaleStudy/docs/codex-review-rules
docs: add Codex code review rules to AGENTS.md
2 parents aeb1dda + 2b88e7e commit beeba97

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

โ€ŽAGENTS.mdโ€Ž

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,3 +112,12 @@ vi.mock("../utils/github.js", () => ({
112112
- **๋Œ“๊ธ€ ์ˆจ๊น€ ๋งˆ์ปค(`<!-- xxx-data: ... -->`)์˜ ์ง๋ ฌํ™” ํ˜•์‹์„ ๋ฐ”๊ฟ€ ๋•Œ๋Š”** ์ •๊ทœ์‹, ๋ฌธ์„œ ์ฃผ์„, ํ…Œ์ŠคํŠธ๋ฅผ ๊ฐ™์€ PR ์—์„œ ํ•จ๊ป˜ ๊ณ ์นœ๋‹ค. ํŒŒ์‹ฑ์ด ๋นˆ ๊ฐ’์œผ๋กœ fallback ํ•˜๋ฉด ํšŒ๊ท€๊ฐ€ ์กฐ์šฉํžˆ ๋ฌปํžŒ๋‹ค.
113113
- ์‘๋‹ต์—๋Š” CORS ํ—ค๋”(`Access-Control-Allow-Origin: *`)๊ฐ€ ๋ถ™๊ณ , ์—๋Ÿฌ๋Š” 500 ์œผ๋กœ ๋Œ๋ ค์ค€๋‹ค. ์›์ธ์€ `wrangler tail` ๋กœ ๋ณธ๋‹ค.
114114
- 401 ์ด ๋‚˜๋ฉด `APP_ID` ์™€ `PRIVATE_KEY` ๊ฐ€ ๊ฐ™์€ App ์˜ ๊ฒƒ์ธ์ง€ ํ™•์ธํ•œ๋‹ค.
115+
116+
## Code Review Rules
117+
118+
- Node.js ๋‚ด์žฅ ๋ชจ๋“ˆ์ด๋‚˜ Octokit ๊ฐ™์€ Workers ๋Ÿฐํƒ€์ž„์—์„œ ๋™์ž‘ํ•˜์ง€ ์•Š๋Š” ํŒจํ‚ค์ง€๋ฅผ ์“ฐ๋ฉด ์ง€์ ํ•œ๋‹ค.
119+
- GraphQL ์ฟผ๋ฆฌ์— ๋ฌธ์ž์—ด๋กœ ๋ผ์›Œ ๋„ฃ๋Š” ๊ฐ’์€ ๋ฐ˜๋“œ์‹œ ๊ฒ€์ฆ๋˜์–ด์•ผ ํ•œ๋‹ค. ์‚ฌ์šฉ์ž ์ž…๋ ฅ(PR ์ œ๋ชฉ, ๋Œ“๊ธ€ ๋“ฑ)์ด ๊ฒ€์ฆ ์—†์ด ๋“ค์–ด๊ฐ€๋ฉด ์‹ฌ๊ฐํ•œ ๋ฌธ์ œ๋กœ ์ง€์ ํ•œ๋‹ค.
120+
- ์ƒˆ ์—”๋“œํฌ์ธํŠธ๋Š” ๊ธฐ์กด์ฒ˜๋Ÿผ `repo_owner`๊ฐ€ `DaleStudy`๊ฐ€ ์•„๋‹ˆ๋ฉด 403์„ ๋Œ๋ ค์•ผ ํ•˜๊ณ , `/internal/*`๋Š” `X-Internal-Secret`์„ ๊ฒ€์‚ฌํ•ด์•ผ ํ•œ๋‹ค.
121+
- `tagPatterns`๋‚˜ `postLearningStatus`์— fetch๊ฐ€ ๋Š˜์–ด๋‚˜๋ฉด `tests/subrequest-budget.test.js`์˜ ๊ณ ์ •๊ฐ’๋„ ํ•จ๊ป˜ ๊ฐฑ์‹ ๋˜์–ด์•ผ ํ•œ๋‹ค.
122+
- ๋Œ“๊ธ€ ์ˆจ๊น€ ๋งˆ์ปค(`<!-- xxx-data: ... -->`) ํ˜•์‹์„ ๋ฐ”๊พธ๋ฉด ํŒŒ์‹ฑ ์ •๊ทœ์‹๊ณผ ํ…Œ์ŠคํŠธ๋„ ๊ฐ™์€ PR์—์„œ ๋ฐ”๋€Œ์–ด์•ผ ํ•œ๋‹ค.
123+
- ์ƒˆ ์‹œํฌ๋ฆฟ์„ `wrangler secret put` ์ „์ œ๋กœ ์ถ”๊ฐ€ํ•˜๋ฉด ์ง€์ ํ•œ๋‹ค. ์‹œํฌ๋ฆฟ์€ GitHub secret์œผ๋กœ ๋‘๊ณ  ๋ฐฐํฌ ์›Œํฌํ”Œ๋กœ๊ฐ€ ๋„ฃ๋Š”๋‹ค.

0 commit comments

Comments
ย (0)