From eaf60a03b27914c2211e4a7eb4a78f8ca52a6d06 Mon Sep 17 00:00:00 2001 From: Neraste Date: Tue, 7 Apr 2026 01:45:42 +0200 Subject: [PATCH 1/2] Fix incorrect karaoke field in PlayerTokenSerializer Fixes #188. --- dakara_server/playlist/serializers.py | 9 ++++++++- dakara_server/playlist/tests/test_player_token.py | 4 ++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/dakara_server/playlist/serializers.py b/dakara_server/playlist/serializers.py index ad461bf..71aa766 100644 --- a/dakara_server/playlist/serializers.py +++ b/dakara_server/playlist/serializers.py @@ -300,11 +300,18 @@ class Meta: class PlayerTokenSerializer(serializers.ModelSerializer): - karaoke_id = serializers.PrimaryKeyRelatedField(read_only=True) + # get related karaoke field + karaoke = serializers.PrimaryKeyRelatedField(many=False, read_only=True) + + # set related karaoke field + karaoke_id = serializers.PrimaryKeyRelatedField( + write_only=True, source="karaoke", queryset=Karaoke.objects.all() + ) class Meta: model = PlayerToken fields = ( + "karaoke", "karaoke_id", "key", ) diff --git a/dakara_server/playlist/tests/test_player_token.py b/dakara_server/playlist/tests/test_player_token.py index f7968ed..ccd968d 100644 --- a/dakara_server/playlist/tests/test_player_token.py +++ b/dakara_server/playlist/tests/test_player_token.py @@ -23,7 +23,7 @@ def test_create(self): self.authenticate(self.manager) # create the token - response = self.client.post(self.url, {"karaoke": karaoke.id}) + response = self.client.post(self.url, {"karaoke_id": karaoke.id}) self.assertEqual(response.status_code, status.HTTP_201_CREATED) # check the token exists @@ -56,7 +56,7 @@ def test_get(self): self.assertEqual(len(response.data["key"]), 40) self.assertEqual(response.data["key"], player_token.key) - self.assertEqual(response.data["karaoke_id"], player_token.karaoke.id) + self.assertEqual(response.data["karaoke"], player_token.karaoke.id) def test_get_not_found(self): """Test to get a token that doesn't exist""" From 27b100f3679a41a168e074b0c3760e3ea0acc812 Mon Sep 17 00:00:00 2001 From: Neraste Date: Tue, 7 Apr 2026 01:47:12 +0200 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 435df4d..06b885e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -40,6 +40,10 @@ Any important notes regarding the update. - Allow to search playlist entries, player errors, users, and song tags. - Allow to search songs, playlist entries, player errors and users by ID. +### Fixed + +- Fixed a bug when creating a player token with a MariaDB database. + ## 1.9.2 - 2025-03-22 ## 1.9.1 - 2025-03-15