Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAM ADC Simple Window: Incorrect ADC Peak #84

Open
aeoranday opened this issue Oct 14, 2024 · 0 comments
Open

TAM ADC Simple Window: Incorrect ADC Peak #84

aeoranday opened this issue Oct 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@aeoranday
Copy link
Member

aeoranday commented Oct 14, 2024

ta.adc_peak = latest_tp_in_window.adc_peak;

The assignment of the ADC peak for this algorithm is not true to the TP contents. There is no calculation done for what the ADC peak actually is since it strictly uses the last TP in the window. This may be true of other algorithms which make use of TPWindow, but I have not yet checked.

It may be worth it to keep track of the argmax of ADC peak for the TP list in TPWindow for easier updating for the moving window and assignment during TA construction.

@aeoranday aeoranday added the bug Something isn't working label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant