Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation of unit tests, linting and clang format checks #405

Closed
jcfreeman2 opened this issue Nov 1, 2024 · 1 comment
Closed

Automation of unit tests, linting and clang format checks #405

jcfreeman2 opened this issue Nov 1, 2024 · 1 comment
Assignees

Comments

@jcfreeman2
Copy link
Collaborator

At the v5.2 release meeting yesterday Eric mentioned the usefulness of running unit tests and clang format checks automatically. One problem I raised at the time is that the llvm package which is used for clang formatting (and linting) is several gigabytes and therefore, although on /cvmfs, not in the images in which we perform our nightly build. Having said that, there's no reason we couldn't just create a GitHub Action which runs directly on one of our self-hosted runners, sets up a work area, checks out our repos, and then runs dbt-build --unittest --lint, as well as dbt-clang-format.sh. The difficult part here would be figuring out how best to report the results, beyond just going through the full log of the output.

@andrewmogan
Copy link
Collaborator

Addressed by #411 and #414.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants