Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the CMake version #344

Closed
jcfreeman2 opened this issue Feb 1, 2024 · 1 comment
Closed

Bump the CMake version #344

jcfreeman2 opened this issue Feb 1, 2024 · 1 comment

Comments

@jcfreeman2
Copy link
Collaborator

Long build times - O(10 minutes) - have been observed building the full OKS stack as described here. One major contributor appears to be the fact that thanks to recursive dependencies, find_package/find_dependency gets called about 3000 times during that build. This (theoretically unnecessary) recursion, which we get with our current version of CMake (v3.23.1) apparently got fixed in CMake v3.26 (https://cmake.org/cmake/help/latest/module/CMakeFindDependencyMacro.html). We should bump CMake accordingly.
@jcfreeman2
Copy link
Collaborator Author

Version got bumped a couple of weeks ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcfreeman2