Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce length of release paths #337

Closed
jcfreeman2 opened this issue Jan 16, 2024 · 0 comments · Fixed by #341
Closed

Reduce length of release paths #337

jcfreeman2 opened this issue Jan 16, 2024 · 0 comments · Fixed by #341

Comments

@jcfreeman2
Copy link
Collaborator

For a long time, we've been limited in what names we can give our releases because Spack can't handle path lengths beyond 127 characters. In fact, we're bumping right against the limit - the base release in our candidate releases has a name like rc-v4.3.0-2 rather than rc-dunedaq-v4.3.0-2 because of this limit. Similarly, in this GitHub Action for the purposes of demonstration I tried making a nightly release with the name NABABCDEFG24-01-16 and it didn't work - meaning a nightly release with a name such as NAOFFLINE24-01-16 also wouldn't work.

So how should we reduce the length? Let's look at the immediate parent directory of last night's far detector nightlies:

/cvmfs/dunedaq-development.opensciencegrid.org/nightly/NFD24-01-16/spack-0.20.0-gcc-12.1.0/spack-0.20.0/opt/spack/linux-scientific7-x86_64/gcc-12.1.0/

You can see that both spack-0.20.0 and gcc-12.1.0 appear twice in the path. So one option would be to simply drop the spack-0.20.0-gcc-12.1.0 subdirectory, and we'd have:

/cvmfs/dunedaq-development.opensciencegrid.org/nightly/NFD24-01-16/spack-0.20.0/opt/spack/linux-scientific7-x86_64/gcc-12.1.0/

another would be to simply rename spack-0.20.0-gcc-12.1.0 to gcc-12.1.0:

/cvmfs/dunedaq-development.opensciencegrid.org/nightly/NFD24-01-16/gcc-12.1.0/spack-0.20.0/opt/spack/linux-scientific7-x86_64/gcc-12.1.0/

These seem to be the two reasonable choices, in fact.

jcfreeman2 added a commit to DUNE-DAQ/daq-buildtools that referenced this issue Jan 18, 2024
jcfreeman2 added a commit that referenced this issue Jan 18, 2024
jcfreeman2 added a commit to DUNE-DAQ/daq-buildtools that referenced this issue Jan 22, 2024
… from DUNE-DAQ/daq-release#337 that daq-buildtools remains backwards compatible with the earlier directory structure
jcfreeman2 added a commit that referenced this issue Jan 23, 2024
…backwards compatible with daq-buildtools v7.5.0
jcfreeman2 added a commit that referenced this issue Jan 23, 2024
jcfreeman2 added a commit that referenced this issue Jan 23, 2024
…backwards compatible with daq-buildtools v7.5.0
@jcfreeman2 jcfreeman2 linked a pull request Jan 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant