Review of CI/CD pull request

[fkiraly]

Review of PR #7, since it has already been merged:

• pyproject.toml - consider moving some dependencies to an optional dev or tests dependency set. Not all seem to be required to run the package itself.
• all tests were deleted in Task 4 (a|b) Migrate CI/CD from GitLab to GitHub Actions #7 - is this intented?
  • @xandie985 said they were deleted because they were failing. Tests did not match the code.
  • you need to have a plan that you do not lose the tests. Having them in local is not a good strategy.
  • strongly recommended: add these with xfail - open new PR; add al lthe tests back; add a pytest xfail or skip to them.
  • as you resolve errros, remove the skip or xfails.
• PR Task 4 (a|b) Migrate CI/CD from GitLab to GitHub Actions #7 also has a lot of changes to the core logic, e.g., time_series_d1.py, time_series_d2.py - I thought this just added CI. Is this a mistake?
• configuration for linting (ruff, black) is added, but the checks are not actually run in the CI

[xandie985]

Hi @fkiraly , thank you for the feedback.

1. yes, for this current issue of pyproject.toml, I will create an MR that deals with resolving it plus the other points you've mentioned.
2. Yes, the tests were deleted here because, This branch was supposed to fill in the CICD gap that I was facing during D1 & D2 layer implementation. Since the main objective here would be to only focus of the Github workflows, I refrained from adding code related to D1 and D2 layers since they were already already contained in Task 1.2 (a) Move Development Code related to D1 layer #4 and Task 1.2 (b) Move Development Code related to D2 #5 .
3. Yes the changes you see here is because we had discussion to keep the code/test cases as it is. So, I had to introduce these files, Since the branch is already merged now, I get your perspective only to keep the test files and handle them with xfail. Whereas I was thinking to keep the files + tests cases so they at least pass at this stage, and further developments related to D1 and D2 would be handled in future PRs.
4. In the current MR, related to this issue, I will handle these enhancements too.