From 70eb696da380319aceafe472a4dd5f3f8591060d Mon Sep 17 00:00:00 2001 From: Michael Vasseur <14887731+vmcj@users.noreply.github.com> Date: Fri, 4 Apr 2025 19:02:36 +0200 Subject: [PATCH] Only get freezedata on existing contests This is a annoying case, we only check if the contests exists after we know if the user has access. This prevents us from disclosing data but does require this null check. --- webapp/src/Controller/API/ContestController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapp/src/Controller/API/ContestController.php b/webapp/src/Controller/API/ContestController.php index 388287c6b3..b4477cc30a 100644 --- a/webapp/src/Controller/API/ContestController.php +++ b/webapp/src/Controller/API/ContestController.php @@ -364,7 +364,7 @@ public function problemsetAction(Request $request, string $cid): Response $hasAccess = $this->dj->checkrole('jury') || $this->dj->checkrole('api_reader') || - $contest->getFreezeData()->started(); + $contest?->getFreezeData()->started(); if (!$hasAccess) { throw new AccessDeniedHttpException();