Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing lines and redrawing polys, Make Polygons tool #62

Open
BenjiDa opened this issue Mar 17, 2021 · 7 comments
Open

Editing lines and redrawing polys, Make Polygons tool #62

BenjiDa opened this issue Mar 17, 2021 · 7 comments

Comments

@BenjiDa
Copy link

BenjiDa commented Mar 17, 2021

I'm having issues redrawing polys after editing ContactsAndFaults lines or relabeling MapUnitPoints. The issue I am having is that after editing and redrawing polygons I have many polygons that have multiple labels and I have to edit those manually.

As the tool says:
Attributes polygons using (1) attributes of any existing polyygons in MapUnitPolys and (2) if a label points feature class is specified, attributes of points in this feature class.

Is there a certain advantage to using attributes from existing polygons? Seems perhaps more efficient to do one option or the other, in my case only the second option.

@ethoms-usgs
Copy link
Collaborator

Of course, it depends on your workflow, but mine has always been to

  1. create label points as I am digitizing lines, before any polygons have been created,
  2. create polygons using the label points, and
  3. more or less forget about label points after that.

I haven't actually worked on a map in a long time, but when I was last doing a lot of editing, when new polygons were created (after editing linework) that didn't have attributes, I would just copy and paste attributes, rather than building a new label point to be used at the time of building polygons.

Does that make sense or help somehow?

@BenjiDa
Copy link
Author

BenjiDa commented Mar 17, 2021

That makes sense. My workflow sounds the same up until point 3. Whenever I edit contact or fault lines I always create a new label point if my newly edited lines intersect creating what will be a new polygon. It would be interesting to hear input from others on this. Is it possible to give the tool the option to take attributes from either existing polygons or label points rather than both? Would that mess up some other part of your workflow?

@LindaTedrow
Copy link

LindaTedrow commented Mar 17, 2021 via email

@ethoms-usgs
Copy link
Collaborator

It might more complicated than necessary but the tool is supposed to be able to work with both sources of attributes. Can you give more details about it seems to be failing? Are you checking the errors_ feature classes if they get created?

@BenjiDa
Copy link
Author

BenjiDa commented Mar 18, 2021

Thanks @ethoms-usgs, Yes I am checking the the errors_multilabelPolys, which shows all the doubly labeled polygons. The code isn't failing, it just seems like it is prone to producing multilabel polygons, I was just trying to understand the best workflow for using it. Seems like if I stop relying on label points than it might be smoother.

@ethoms-usgs
Copy link
Collaborator

Ok, good to know. I will have to set up an mxd with some dummy data to check this out, but will try to make sure it works as you are expecting it to.

@ethoms-usgs
Copy link
Collaborator

Hi everyone,
After Issue 64 was posted, I took a look at the Make Polygons tool but I could not get it to run without errors or hanging. So, I resurrected some simpler code I wrote years ago after becoming frustrated with the Topology and Shared Edit tools and added it to the toolbox as the Rebuild MapUnit Polygons tool. This is in version v1.6. The main differences are that it doesn't try to concatenate label points from polygons-turned-to-points and an optional label points featureclass; it uses one or the other, and it doesn't do any error checking. If you prefer this simpler approach, great, but if you prefer the functionality of the Make Polygons tool, I or Ralph will try it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants