Skip to content

Commit 4581dbc

Browse files
committed
Some minor fixes to science data and labs
1 parent 81b5e53 commit 4581dbc

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Source/DMSeismicHandler.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,7 @@ public static ScienceData makeData(DMSeismometerValues sensor, float score, Scie
402402
sub.title = exp.experimentTitle + string.Format(" from {0}'s {1}", body.theName, biome);
403403
}
404404

405-
return new ScienceData(science, 1f, 1f, sub.id, sub.title, false, sensor.ID);
405+
return new ScienceData(science, 1f, v.VesselValues.ScienceReturn.value, sub.id, sub.title, false, sensor.ID);
406406
}
407407

408408
private static void registerDMScience(DMAsteroidScience newAst, ScienceExperiment exp, ScienceSubject sub)

Source/Part Modules/DMAsteroidScanner.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -774,7 +774,7 @@ private ScienceData makeScience(float dist, ModuleAsteroid m)
774774
registerDMScience(ast, sub);
775775
body.bodyName = asteroidBodyNameFixed;
776776

777-
data = new ScienceData(multiplier * exp.baseValue * sub.dataScale, transmitValue, 0f, sub.id, dataTitle, false, part.flightID);
777+
data = new ScienceData(multiplier * exp.baseValue * sub.dataScale, transmitValue, vessel.VesselValues.ScienceReturn.value, sub.id, dataTitle, false, part.flightID);
778778

779779
return data;
780780
}

Source/Part Modules/DMModuleScienceAnimate.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ public void deployAction(KSPActionParam param)
479479
public virtual void retractEvent()
480480
{
481481
if (oneWayAnimation) return;
482-
if (oneShot) return;
482+
if (oneShot && !HighLogic.LoadedSceneIsEditor) return;
483483
primaryAnimator(-1f * animSpeed, 1f, WrapMode.Default, animationName, anim);
484484
IsDeployed = false;
485485
if (USScience)
@@ -952,7 +952,7 @@ private ScienceData makeScience(float boost, ExperimentSituations vesselSituatio
952952
sub.scienceCap = scienceExp.scienceCap * sub.subjectValue;
953953
}
954954

955-
data = new ScienceData(scienceExp.baseValue * sub.dataScale, xmitDataScalar, 1f, sub.id, sub.title, false, part.flightID);
955+
data = new ScienceData(scienceExp.baseValue * sub.dataScale, xmitDataScalar, vessel.VesselValues.ScienceReturn.value, sub.id, sub.title, false, part.flightID);
956956

957957
return data;
958958
}
@@ -992,7 +992,7 @@ private void newResultPage()
992992
if (storedScienceReports.Count > 0)
993993
{
994994
ScienceData data = storedScienceReports[dataIndex];
995-
ExperimentResultDialogPage page = new ExperimentResultDialogPage(part, data, data.transmitValue, labDataBoost, (experimentsReturned >= (experimentLimit - 1)) && !rerunnable, transmitWarningText, true, new ScienceLabSearch(vessel, data), new Callback<ScienceData>(onDiscardData), new Callback<ScienceData>(onKeepData), new Callback<ScienceData>(onTransmitData), new Callback<ScienceData>(onSendToLab));
995+
ExperimentResultDialogPage page = new ExperimentResultDialogPage(part, data, data.transmitValue, 0, (experimentsReturned >= (experimentLimit - 1)) && !rerunnable, transmitWarningText, true, new ScienceLabSearch(vessel, data), new Callback<ScienceData>(onDiscardData), new Callback<ScienceData>(onKeepData), new Callback<ScienceData>(onTransmitData), new Callback<ScienceData>(onSendToLab));
996996
ExperimentsResultDialog.DisplayResult(page);
997997
}
998998
}
@@ -1024,7 +1024,7 @@ private void initialResultsPage()
10241024
if (scienceReports.Count > 0)
10251025
{
10261026
ScienceData data = scienceReports[0];
1027-
ExperimentResultDialogPage page = new ExperimentResultDialogPage(part, data, data.transmitValue, labDataBoost, (experimentsReturned >= (experimentLimit - 1)) && !rerunnable, transmitWarningText, true, new ScienceLabSearch(vessel, data), new Callback<ScienceData>(onDiscardInitialData), new Callback<ScienceData>(onKeepInitialData), new Callback<ScienceData>(onTransmitInitialData), new Callback<ScienceData>(onSendInitialToLab));
1027+
ExperimentResultDialogPage page = new ExperimentResultDialogPage(part, data, data.transmitValue, 0, (experimentsReturned >= (experimentLimit - 1)) && !rerunnable, transmitWarningText, true, new ScienceLabSearch(vessel, data), new Callback<ScienceData>(onDiscardInitialData), new Callback<ScienceData>(onKeepInitialData), new Callback<ScienceData>(onTransmitInitialData), new Callback<ScienceData>(onSendInitialToLab));
10281028
ExperimentsResultDialog.DisplayResult(page);
10291029
}
10301030
}

0 commit comments

Comments
 (0)