-
Notifications
You must be signed in to change notification settings - Fork 41
Open
Labels
effort::lowLow effort expected to solve issue.Low effort expected to solve issue.enhancementNew feature or requestNew feature or requestp::FlowControlConcerns package FlowControl or Undirected.FlowControlConcerns package FlowControl or Undirected.FlowControlpriority::lowShould be treated with low priorityShould be treated with low priority
Milestone
Description
Deprecation of Cvs_US and Cvs_UK in ThermofluidStream
Background
In ThermofluidStream.FlowControl.BasicControlValve and ThermofluidStream.FlowControl.SpecificValveType, the main flow coefficient parameter is Kvs (SI-compliant). There are also optional legacy parameters:
Cvs_US- US customary units (gpm at 1 psi)Cvs_UK- UK imperial units (UK gallons per minute at 1 psi)
Issues
- Non-SI units: Both
Cvs_USandCvs_UKare not SI-compliant, which conflicts with the rest of the Modelica standard library. - Conversion required:
Kv ≈ 0.865 · Cv_USKv ≈ 0.72 · C_uk
This adds unnecessary complexity and potential for user error.
- Legacy usage:
Cvs_UKis a historical unit rarely used today.Cvs_USis also less relevant for SI-based libraries and global applications.
Recommendation
- Deprecate both
Cvs_USandCvs_UKfor v1.3. The user can set them but this will create a warning, noting that they will be removed in v2.0, encouraging the users to switch toKvsfor SI-consistent modeling.
This approach simplifies the API, ensures consistency, and aligns with Modelica and IEC/EN standards.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
effort::lowLow effort expected to solve issue.Low effort expected to solve issue.enhancementNew feature or requestNew feature or requestp::FlowControlConcerns package FlowControl or Undirected.FlowControlConcerns package FlowControl or Undirected.FlowControlpriority::lowShould be treated with low priorityShould be treated with low priority