Skip to content

fix debug plugin use-after-free on shutdown (LTO) #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+5 −2
Closed

fix debug plugin use-after-free on shutdown (LTO) #5667

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55cdb83
fix debug plugin use-after-free on shutdown
dhthwy Nov 26, 2025
eb8ba90
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions library/include/DebugManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,11 @@ class DFHACK_EXPORT DebugManager : public std::vector<DebugCategory*> {

//! Get the singleton object
static DebugManager& getInstance() {
static DebugManager instance;
return instance;
// Plugins may still hold pointers to DebugManager's instance during shutdown.
// If DebugManager's dtor runs first, use-after-free may ensue.
// Intentionally leak to avoid this issue.
static DebugManager* instance = new DebugManager();
return *instance;
}

// don't bother to protect these with mutexes. we don't want to pay the
Expand Down