GetVector: check that item is a table before iterating

lethosor · lethosor · commit 64df6c62ff2e · 2024-06-06T13:30:51.000-04:00
This fixes many crashes in API functions that used GetVector() without this check
diff --git a/library/LuaTools.cpp b/library/LuaTools.cpp
@@ -122,6 +122,7 @@ void DFHack::Lua::Push(lua_State *state, const df::coord2d &pos)
 
 void DFHack::Lua::GetVector(lua_State *state, std::vector<std::string> &pvec, int idx)
 {
+    luaL_checktype(state, idx, LUA_TTABLE);
     lua_pushnil(state);   // first key
     while (lua_next(state, idx) != 0)
     {

Original file line number	Diff line number	Diff line change
`@@ -122,6 +122,7 @@ void DFHack::Lua::Push(lua_State *state, const df::coord2d &pos)`
`122`	`122`
`123`	`123`	`void DFHack::Lua::GetVector(lua_State *state, std::vector<std::string> &pvec, int idx)`
`124`	`124`	`{`
	`125`	`+ luaL_checktype(state, idx, LUA_TTABLE);`
`125`	`126`	`lua_pushnil(state); // first key`
`126`	`127`	`while (lua_next(state, idx) != 0)`
`127`	`128`	`{`