PAE-502: eslint no unused vars

[loveboat]

Ticket: PAE-502

Description

eslint no unused vars - this came up whilst I was doing the /dev endpoint. seems we were missing a few of these

---

Please see the Pull Requests standards.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[carlesandres]

lgtm. I'm aware we are not supposed to write our own eslint rules but the current config is getting in the way of our deadlines while providing very little value.

I think we can always consider alternatives to the custom linting rule in the future if there's appetite.

[loveboat]

lgtm. I'm aware we are not supposed to write our own eslint rules but the current config is getting in the way of our deadlines while providing very little value.

I think we can always consider alternatives to the custom linting rule in the future if there's appetite.

I added this mainly to catch a bunch of unused vars that we were leaving dangling