Change import to use in sass files
#3316
Conversation
| border-style: solid; | ||
| border-color: black; | ||
| border-color: variables.$grey-color; |
There was a problem hiding this comment.
meaningful change (it winds up a darker shade of gray), but I think it's more one of those 'how was this ever working' kinda things
| @@ -1,12 +1,13 @@ | |||
| // Styles pertaining to the login form or other devise-related views. | |||
|
|
|||
| @import './_variables'; | |||
| @use 'bootstrap/scss/bootstrap'; | |||
There was a problem hiding this comment.
There are a few cases where we're importing bootstrap in a place we weren't before, and it's generally because we're extending some bootstrap class (here, card-header).
| } | ||
|
|
||
| body { | ||
| font-family: "Source Sans Pro", sans-serif; |
There was a problem hiding this comment.
This is being applied wrong with use, and popping it out makes it match what's happening in sandbox
| } | ||
|
|
||
| .form-check-label { | ||
| @extend .ml-8; | ||
| @extend .ml-5; |
There was a problem hiding this comment.
for some reason spacers are being applied differently (properly?) now; stuff over 5 gets a little spotty or doesn't acknowledge/style correctly, and other stuff seems to be a little more aggressive/spacious. (There are a bunch of corresponding HTML changes to reflect this, but it all more or less shakes out in the end.)
| @@ -1,6 +1,6 @@ | |||
| <!-- locals: title, table_type (for div id and tbody div id), pregnancies, sortable, autosortable --> | |||
|
|
|||
| <div id="<%= table_type %>" class="margin-bottom mt-5"> | |||
| <div id="<%= table_type %>" class="margin-bottom mt-4"> | |||
There was a problem hiding this comment.
lots of changes like this in the html, where we gently crank down the margins so there's nt a lot of dead whitespace.
| <%= render 'patients/menu', patient: @patient %> | ||
| </div> | ||
|
|
||
| <div id="sections" class="col tab-content"> | ||
| <div id="sections" class="col tab-content mt-3"> |
There was a problem hiding this comment.
this lets us take it out of header elements in the patient tabs
I rule and have completed some work on Case Manager that's ready for review!
One of the deprecation warnings we were getting was
importbeing deprecated in favor of use. Predictably no good deed goes unpunished here.This pull request makes the following changes:
importout foruseno meaningful view changes, and counting on system tests to not break anything meaningful (though I also clicked around the app a bunch)
It relates to the following issue #s:
@importand global built-in functions #3311For reviewer:
featureif it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.dependenciesif it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.