[FAIL. Reason: Raffle__upkeepNotNeeded(10000000000000000 [1e16], 1, 0)]

[vigneshbalu96]

While executing the test command in the smart contract Raffle

forge test --mt testDontAllowPlayersToEnterWhileRaffleIsCalculation -vvvv

Here is my perform Upkeep Function

    function performUpkeep(bytes calldata /* performData */) external {
        (bool upkeepNeeded, ) = checkUpkeep("");
        if (!upkeepNeeded) {
            revert Raffle__upkeepNotNeeded(
                address(this).balance,
                s_players.length,
                uint256(s_raffleState)
            );
        }

        s_raffleState = RaffleState.calculating;

        uint256 requestId = s_vrfCoordinator.requestRandomWords(
            VRFV2PlusClient.RandomWordsRequest({
                keyHash: i_keyHash,
                subId: i_subscriptionId,
                requestConfirmations: REQUEST_CONFIRMATIONS,
                callbackGasLimit: i_callbackGasLimit,
                numWords: NUM_WORDS,
                extraArgs: VRFV2PlusClient._argsToBytes(
                    VRFV2PlusClient.ExtraArgsV1({nativePayment: false})
                )
            })
        );
    }

Here is my testDontAllowPlayersToEnterWhileRaffleIsCalculation Function which uses PerformUpkeep.

    function testDontAllowPlayersToEnterWhileRaffleIsCalculation() public {
        // Assert / Assert
        vm.prank(PLAYER);
        raffle.enterRaffle{value: entranceFee}();
        vm.warp(block.timestamp + interval + 1);
        vm.roll(block.number + 1);
        raffle.performUpkeep("");

        // Act / Assert
        vm.expectRevert(Raffle.Raffle__RaffleNotOpen.selector);
        vm.prank(PLAYER);
        raffle.enterRaffle{value: entranceFee}();
    }

I get the error at this specific section

Any help could be appreciated! 😍

[EngrPips]

Hello @vigneshbalu96, add interval to vm.roll too and retry. Let's see if that helps at all.

[vigneshbalu96]

@EngrPips , No that doesn't worked.

[EngrPips]

Show your checkUpkeep function as @KMean suggested.

[vigneshbalu96]

Yup sure! @EngrPips

[EngrPips]

Yeah, I will let them take the shot.

[KMean]

Hey @vigneshbalu96 can you share your checkUpkeep function? looks like something is still returning false in there.

[vigneshbalu96]

@KMean , Sharing the checkUpkeep function for the reference.

    function checkUpkeep(
        bytes memory /* checkData */
    ) public view returns (bool upkeepNeeded, bytes memory /* performData */) {
        bool timeHasPassed = ((block.timestamp - s_lastTimeStamp) >=
            i_interval);
        bool isOpen = s_raffleState == RaffleState.calculating;
        bool hasBalance = address(this).balance > 0;
        bool hasPlayers = s_players.length > 0;

        upkeepNeeded = (timeHasPassed && isOpen && hasBalance && hasPlayers);
        return (upkeepNeeded, "0x0");
    }

Thanks In Advance...!

[vigneshbalu96]

Is there any issue with this chunk of code...?

bool isOpen = s_raffleState == RaffleState.calculating;

calculating........... 🤔

[EngrPips]

Yeah, it is supposed to check if the lottery is OPEN not CALCULATING

[vigneshbalu96]

Keeping it open works as expected and the tests are passing fine.

Thanks Mates 🎉 @EngrPips @KMean

[EngrPips]

Anytime, Friend. Keep crushing it.