Lesson11: Base64.encode(abi.encodePacked(svg)) == Base64.encode(bytes(string(abi.encodePacked(svg)))), is that possible?

[codeplay22]

in DeployMoodNft.s.sol
in this code Base64.encode(bytes(string(abi.encodePacked(svg)))) why we are converting it to bytes and then to strings and then again to bytes and then again to strings(Base64). if we simply can do this Base64.encode(abi.encodePacked(svg) which gives the same output as well. check out in the image below.

[EngrPips]

Hello @codeplay22 That is a good catch, and I must say you are correct, but Patrick is a really security-minded person, and he will always do everything to be safe rather than sorry. Some things seem to work the same on a surface level, but when they are battle-tested, you will get to realize why the extra step was needed. This doesn't mean that doing it the way you have stated will definitely lead to a security issue, but I am just talking from the perspective with which I look at it when I see Patrick do stuff in more complicated ways

[codeplay22]

@EngrPips yeah, Thanks for taking your time looking at my code brother, but i want to know exactly why he did that way?

[codeplay22]

Hi @PatrickAlphaC i wanted to know why you first encoded it from bytes to strings then again to bytes and then finally to strings by using this Base64.encode(bytes(string(abi.encodePacked(svg)))); ? whereas you could just do Base64.encode(abi.encodePacked(svg)) instead.
why did you do that?

[PatrickAlphaC]

Whoops! Probably because I wasn't thinking clearly!

[codeplay22]

Hi @PatrickAlphaC
Thanks a lot for taking time to read my code, i understand it happens.
Thanks a lot for replying though.
But i was wondering what to mark the answer?

[EngrPips]

Whoops! Probably because I wasn't thinking clearly!

This is the answer because you wanted to why and clearly here he stated why

[codeplay22]

@EngrPips no, i asked that to know the concept behind it only.
So according to patrick i think answer would be to use it like this only Base64.encode(abi.encodePacked(svg))

and the same thing can be done here as well in Moodnft.s.sol

there's no need to convert abi.EncodePacked to bytes you can remove it and it will work fine.

Like that -

[EngrPips]

I see.