Replies: 6 comments 14 replies
-
|
Hello @NickyBenz, Can you please check that |
Beta Was this translation helpful? Give feedback.
-
|
Sure, no problem. `[10933784] Actual_Invariants::setUp() [214] Handler::depositCollateral(0x6675c9C78c7a6D335b85f23992cf7e07a7B38cD4, 1967808702692547613377325 [1.967e24]) |
Beta Was this translation helpful? Give feedback.
-
|
Mind adding your main test also? |
Beta Was this translation helpful? Give feedback.
-
|
From the output you shared, I noticed that the address that was used when the fuzzer called │ ├─ [641] DSCEngine::getTokenAddresses(0) [staticcall]
│ │ └─ ← [Return] 0xA8452Ec99ce0C64f20701dB7dD3abDb607c00496 <= first token address
│ ├─ [641] DSCEngine::getTokenAddresses(1) [staticcall]
│ │ └─ ← [Return] 0xDB8cFf278adCCF9E9b5da745B44E754fC4EE3C76 <= second token address
[214] Handler::depositCollateral(0x6675c9C78c7a6D335b85f23992cf7e07a7B38cD4, 1967808702692547613377325 [1.967e24])
└─ ← [Revert] EvmError: Revert
Can you carefully check your test suite and ensure you didn't wrongly assign values to variables? |
Beta Was this translation helpful? Give feedback.
-
|
will do, thank you very much for your time |
Beta Was this translation helpful? Give feedback.
-
|
unfortunately, I believe the values entered are correct. I even hardcoded the first and second addresses into the function. For some reason, it continued to call with that weird address |
Beta Was this translation helpful? Give feedback.
-
|
Handler Contract contract Handler is Test {
DSCEngine dsc_engine;
DecentralizedStableCoin dsc;
HelperConfig config;
address weth;
address wbtc;
uint256 constant MAX_DEPOSIT_NUMBER = type(uint96).max;
address user = makeAddr("user");
constructor(DSCEngine _dsc_engine, DecentralizedStableCoin _dsc, HelperConfig _config) {
dsc = _dsc;
dsc_engine = _dsc_engine;
config = _config;
(,, weth, wbtc,) = config.activeConfig();
}
//redeem collateral
//call when u have collateral
function depositCollateral(uint256 collateral_seed, uint256 amount_collateral) public {
(ERC20Mock collateraltoken) = _getCollateralfromSeed(collateral_seed);
vm.startPrank(user);
collateraltoken.mint(user, amount_collateral);
amount_collateral = bound(amount_collateral, 1, MAX_DEPOSIT_NUMBER);
dsc_engine.depositCollateral(address(collateraltoken), amount_collateral);
vm.stopPrank();
}
function _getCollateralfromSeed(uint256 collateral_seed) private view returns (ERC20Mock) {
ERC20Mock token_to_deposit;
if (collateral_seed % 2 == 0) {
token_to_deposit = ERC20Mock(weth);
} else {
token_to_deposit = ERC20Mock(wbtc);
}
return (token_to_deposit);
}
} |
Beta Was this translation helpful? Give feedback.
-
|
apologies, not sure why the format is so weird |
Beta Was this translation helpful? Give feedback.
-
|
Deployment // SPDX-License-Identifier: MIT
pragma solidity ^0.8.20;
import {Script} from "../lib/forge-std/src/Script.sol";
import {DSCEngine} from "../src/DSCEngine.sol";
import {ERC20, ERC20Burnable} from "@openzeppelin/contracts/token/ERC20/Extensions/ERC20Burnable.sol";
import {DecentralizedStableCoin} from "../src/DecentralizedStableCoin.sol";
import {HelperConfig} from "./HelperConfig.s.sol";
contract DeployDSCEngine is Script {
DSCEngine engine;
DecentralizedStableCoin modicoin;
uint256 private constant NUMBEROFCOLLATERALTOKENS = 2;
HelperConfig config;
address[] public tokenAddresses;
address[] public priceFeedAddresses;
function run() public returns (DecentralizedStableCoin, DSCEngine, HelperConfig) {
config = new HelperConfig();
(address wethUsdPriceFeed, address wbtcUsdPriceFeed, address weth, address wbtc, uint256 deployerKey) =
config.activeConfig();
tokenAddresses = [weth, wbtc];
priceFeedAddresses = [wethUsdPriceFeed, wbtcUsdPriceFeed];
vm.startBroadcast(deployerKey);
engine = new DSCEngine(tokenAddresses, priceFeedAddresses, address(modicoin));
modicoin = new DecentralizedStableCoin();
modicoin.transferOwnership(address(engine));
vm.stopBroadcast();
return (modicoin, engine, config);
}
} |
Beta Was this translation helpful? Give feedback.
-
|
HelperConfig // SPDX-License-Identifier: MIT
pragma solidity ^0.8.20;
import {MockV3Aggregator} from "./MockV3Aggregator.sol";
import {ERC20Mock} from "@openzeppelin/contracts/mocks/token/ERC20Mock.sol";
import {AggregatorV3Interface} from "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";
import {Script} from "../lib/forge-std/src/Script.sol";
contract HelperConfig is Script {
uint8 private constant _decimals = 8;
uint256 private constant _initialAnswer = 2000e8;
uint256 private constant SEPOLIA_CHAINID = 11155111;
uint256 private constant ANVIL_CHAINID = 31337;
uint256 private constant INITIALTOKENSUPPLY = 1000e8;
int256 private ETH_USD_PRICE = 2000e8;
int256 private BTC_USD_PRICE = 1000e8;
uint256 private DECIMALS = 8;
uint256 private ANVIL_KEY = 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80;
struct NetworkConfig {
address ETHpriceFeed;
address BTCpriceFeed;
address WETHTokenAddress;
address WBTCTokenAddress;
uint256 deployerkey;
}
NetworkConfig public activeConfig;
constructor() {
if (block.chainid == SEPOLIA_CHAINID) {
activeConfig = getSepoliaETHConfig();
} else {
getOrCreateAnvilETHConfig();
}
}
function getSepoliaETHConfig() public view returns (NetworkConfig memory) {
NetworkConfig memory SepoliaConfig = NetworkConfig({
ETHpriceFeed: 0x694AA1769357215DE4FAC081bf1f309aDC325306,
BTCpriceFeed: 0x1b44F3514812d835EB1BDB0acB33d3fA3351Ee43,
WETHTokenAddress: 0xfFf9976782d46CC05630D1f6eBAb18b2324d6B14,
WBTCTokenAddress: 0x29f2D40B0605204364af54EC677bD022dA425d03,
deployerkey: vm.envUint("SEPOLIA_PRIVATE_KEY")
});
return SepoliaConfig;
}
function getOrCreateAnvilETHConfig() public returns (NetworkConfig memory anvil) {
if (activeConfig.ETHpriceFeed != address(0) && activeConfig.BTCpriceFeed != address(0)) {
return activeConfig;
} else {
vm.startBroadcast();
MockV3Aggregator ethUsdPriceFeed = new MockV3Aggregator(_decimals, ETH_USD_PRICE);
ERC20Mock wethMock = new ERC20Mock();
MockV3Aggregator btcUsdPriceFeed = new MockV3Aggregator(_decimals, BTC_USD_PRICE);
ERC20Mock wbtcMock = new ERC20Mock();
activeConfig = NetworkConfig({
ETHpriceFeed: address(ethUsdPriceFeed),
BTCpriceFeed: address(btcUsdPriceFeed),
WETHTokenAddress: address(wethMock),
WBTCTokenAddress: address(wbtcMock),
deployerkey: ANVIL_KEY
});
vm.stopBroadcast();
}
}
function getCurrentNetWorkConfig() public view returns (NetworkConfig memory) {
return activeConfig;
}
} |
Beta Was this translation helpful? Give feedback.
-
|
Invariants ''// SPDX-License-Identifier: MIT
pragma solidity ^0.8.20;
import {Test, console} from "../../lib/forge-std/src/Test.sol";
import {StdInvariant} from "../../lib/forge-std/src/StdInvariant.sol";
import {DecentralizedStableCoin} from "../../src/DecentralizedStableCoin.sol";
import {DSCEngine} from "../../src/DSCEngine.sol";
import {DeployDSCEngine} from "../../script/DeployDSCEngine.s.sol";
import {ERC20Mock} from "@openzeppelin/contracts/mocks/token/ERC20Mock.sol";
import {HelperConfig} from "../../script/HelperConfig.s.sol";
import {AggregatorV3Interface} from "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";
import {MockV3Aggregator} from "../../script/MockV3Aggregator.sol";
import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
import {Handler} from "./Handlers.t.sol";
contract Actual_Invariants is Test {
DecentralizedStableCoin dsc;
HelperConfig config;
DSCEngine dsc_engine;
DeployDSCEngine deployer;
address weth;
address wbtc;
Handler handler;
function setUp() public {
deployer = new DeployDSCEngine();
(dsc, dsc_engine, config) = deployer.run();
(,, weth, wbtc,) = config.activeConfig();
Handler _handler = new Handler(dsc_engine, dsc);
targetContract(address(_handler));
console.log(weth, wbtc);
}
function invariant_musthavemoreCollateralthanDSC() public view {
uint256 total_eth_supply = ERC20Mock(weth).balanceOf(address(dsc_engine));
uint256 total_btc_supply = ERC20Mock(wbtc).balanceOf(address(dsc_engine));
uint256 totaltokensupply = dsc.totalSupply();
uint256 totalcollateralvalue =
dsc_engine.getUSDPrice(weth, total_eth_supply) + dsc_engine.getUSDPrice(wbtc, total_btc_supply);
assert(totalcollateralvalue >= totaltokensupply);
}
} |
Beta Was this translation helpful? Give feedback.
-
|
Handler Contract contract Handler is Test {
DSCEngine dsc_engine;
DecentralizedStableCoin dsc;
HelperConfig config;
address weth;
address wbtc;
uint256 constant MAX_DEPOSIT_NUMBER = type(uint96).max;
address user = makeAddr("user");
constructor(DSCEngine _dsc_engine, DecentralizedStableCoin _dsc, HelperConfig _config) {
dsc = _dsc;
dsc_engine = _dsc_engine;
config = _config;
(,, weth, wbtc,) = config.activeConfig();
}
//redeem collateral
//call when u have collateral
function depositCollateral(uint256 collateral_seed, uint256 amount_collateral) public {
(ERC20Mock collateraltoken) = _getCollateralfromSeed(collateral_seed);
vm.startPrank(user);
collateraltoken.mint(user, amount_collateral);
amount_collateral = bound(amount_collateral, 1, MAX_DEPOSIT_NUMBER);
dsc_engine.depositCollateral(address(collateraltoken), amount_collateral);
vm.stopPrank();
}
function _getCollateralfromSeed(uint256 collateral_seed) private view returns (ERC20Mock) {
ERC20Mock token_to_deposit;
if (collateral_seed % 2 == 0) {
token_to_deposit = ERC20Mock(weth);
} else {
token_to_deposit = ERC20Mock(wbtc);
}
return (token_to_deposit);
}
} |
Beta Was this translation helpful? Give feedback.
-
|
Not an answer but facing a smiliar issue wherein my Handler is not working. //Handler is going to narrow down the ways that we call functions so that we don't waste runs
// SPDX-License-Identifier:MIT
pragma solidity ^0.8.23;
import {Test , console} from "forge-std/Test.sol";
import {StdInvariant} from "forge-std/StdInvariant.sol";
import {DeployScript} from "../../script/DeployDSC.s.sol";
import {DSCEngine} from "../../src/DSCEngine.sol";
import {DecentralizedStableCoin} from "../../src/DecentralizedStableCoin.sol";
import {HelperConfig} from "../../script/HelperConfig.s.sol";
import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
import {ERC20Mock} from "@openzeppelin/contracts/mocks/token/ERC20Mock.sol";
contract Handler is Test{
DSCEngine dsc_engine;
DecentralizedStableCoin dsc;
HelperConfig config;
address weth;
address wbtc;
uint256 constant MAX_DEPOSIT_NUMBER = type(uint96).max;
address user = makeAddr("user");
constructor(DSCEngine _dsc_engine, DecentralizedStableCoin _dsc, HelperConfig _config) {
dsc = _dsc;
dsc_engine = _dsc_engine;
config = _config;
(,, weth, wbtc,) = config.activeConfig();
}
//redeem collateral
//call when u have collateral
function depositCollateral(uint256 collateral_seed, uint256 amount_collateral) public {
(ERC20Mock collateraltoken) = _getCollateralfromSeed(collateral_seed);
vm.startPrank(user);
collateraltoken.mint(user, amount_collateral);
amount_collateral = bound(amount_collateral, 1, MAX_DEPOSIT_NUMBER);
dsc_engine.depositCollateral(address(collateraltoken), amount_collateral);
vm.stopPrank();
}
function _getCollateralfromSeed(uint256 collateralSeed) private view returns(ERC20Mock){
ERC20Mock token_to_deposit;
if(collateralSeed % 2 ==0){
token_to_deposit = ERC20Mock(weth);
} else {
token_to_deposit = ERC20Mock(wbtc);
}
return token_to_deposit;
}
}Here is my Invariant test: //This file should have our invariants... aka properties of the system that should always hold
/**
* Some invariants in our project:
* 1. The total supply of DSC should be lesser than total value of collateral
* 2. Getter view functions should never revert
*/
// SPDX-License-Identifier:MIT
pragma solidity ^0.8.23;
import {Test } from "forge-std/Test.sol";
import {StdInvariant} from "forge-std/StdInvariant.sol";
import {DeployScript} from "../../script/DeployDSC.s.sol";
import {DSCEngine} from "../../src/DSCEngine.sol";
import {DecentralizedStableCoin} from "../../src/DecentralizedStableCoin.sol";
import {HelperConfig} from "../../script/HelperConfig.s.sol";
import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
import {Handler} from "./Handler.t.sol";
contract Invariants is StdInvariant , Test{
DSCEngine dsce;
DecentralizedStableCoin dsc;
HelperConfig config;
Handler handler;
address weth;
address wbtc;
function setUp() public {
DeployScript deployer = new DeployScript();
(dsc , dsce , config ) = deployer.run();
handler = new Handler(dsce, dsc , config);
targetContract(address(handler)); //Tells foundry to go absolutely wild on this
( , , weth , wbtc , ) = config.activeConfig();
}
function invariant_protocolMustHaveMoreValueThanTotalSupply() external view {
//get the value of all the collateral in the protocol
// compare it to the total DSC supply
uint256 totalSupply = dsc.totalSupply();
uint256 totalWethDeposited = IERC20(weth).balanceOf(address(dsce));
uint256 totalWbtcDeposited = IERC20(wbtc).balanceOf(address(dsce));
uint256 wethValue = dsce.getUSDAmount(weth , totalWethDeposited);
uint256 wbtcValue = dsce.getUSDAmount(wbtc , totalWbtcDeposited);
assert((wethValue + wbtcValue) >= (totalSupply));
}
}And lastly, this is my error's log: It says ERC20InsufficientAllowance so I don't know what's going on. I am following from the yt vids and don't know what's wrong. A little help would be appreciated |
Beta Was this translation helpful? Give feedback.
-
|
Ah nevermind got it I am a dumbo! |
Beta Was this translation helpful? Give feedback.
-
|
It would be nice if you pointed out what you were doing wrongly, as it might help @NickyBenz and other people who run into the same problem. |
Beta Was this translation helpful? Give feedback.
-
|
So initially I was getting ERC20InsuffientBalance which I countered with collateral.approve() and then I was getting panicky overflow or underflow for a large value of amount_collateral which I countered using bound(). Here's how my Handler looks now: //Handler is going to narrow down the ways that we call functions so that we don't waste runs
// SPDX-License-Identifier:MIT
pragma solidity ^0.8.23;
import {Test, console} from "forge-std/Test.sol";
import {StdInvariant} from "forge-std/StdInvariant.sol";
import {DeployScript} from "../../script/DeployDSC.s.sol";
import {DSCEngine} from "../../src/DSCEngine.sol";
import {DecentralizedStableCoin} from "../../src/DecentralizedStableCoin.sol";
import {HelperConfig} from "../../script/HelperConfig.s.sol";
import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
import {ERC20Mock} from "@openzeppelin/contracts/mocks/token/ERC20Mock.sol";
contract Handler is Test {
DSCEngine dsc_engine;
DecentralizedStableCoin dsc;
HelperConfig config;
address weth;
address wbtc;
uint256 constant MAX_DEPOSIT_NUMBER = type(uint96).max;
address user = makeAddr("user");
uint96 public constant MAX_DEPOSIT_SIZE = type(uint96).max;
constructor(DSCEngine _dsc_engine, DecentralizedStableCoin _dsc, HelperConfig _config) {
dsc = _dsc;
dsc_engine = _dsc_engine;
config = _config;
(,, weth, wbtc,) = config.activeConfig();
}
//redeem collateral
//call when u have collateral
function depositCollateral(uint256 collateral_seed, uint256 amount_collateral) public {
amount_collateral = bound(amount_collateral, 1, MAX_DEPOSIT_SIZE);
ERC20Mock collateraltoken = _getCollateralfromSeed(collateral_seed);
vm.startPrank(user);
collateraltoken.mint(user, amount_collateral);
collateraltoken.approve(address(dsc_engine), amount_collateral);
dsc_engine.depositCollateral(address(collateraltoken), amount_collateral);
vm.stopPrank();
}
function _getCollateralfromSeed(uint256 collateralSeed) private view returns (ERC20Mock) {
ERC20Mock token_to_deposit;
if (collateralSeed % 2 == 0) {
token_to_deposit = ERC20Mock(weth);
} else {
token_to_deposit = ERC20Mock(wbtc);
}
return token_to_deposit;
}
}
|
Beta Was this translation helpful? Give feedback.
-
|
Interesting. Thanks for the detail |
Beta Was this translation helpful? Give feedback.
-
|
Hello @NickyBenz, tough to catch what is wrong here, but can you make your address[] memory collateral_tokens = dsc_engine.get_collateral_tokens();
weth = ERC20Mock(collateral_tokens[0]);
wbtc = ERC20Mock(collateral_tokens[1]); |
Beta Was this translation helpful? Give feedback.
-
Hi, I've been following the code for the handler function which is on lesson 20 in the Cyfrin course,
Here is my code
`contract Handler is Test {
DSCEngine dsc_engine;
DecentralizedStableCoin dsc;
HelperConfig config;
address weth;
address wbtc;
uint256 constant MAX_DEPOSIT_NUMBER = type(uint96).max;
address user = makeAddr("user");
}
`
When I run this code and put the -vvvv thing it tells me that I have this error
'[192] Handler::depositCollateral(0x6675c9C78c7a6D335b85f23992cf7e07a7B38cD4, 1967808702692547613377325 [1.967e24])
└─ ← [Revert] EvmError: Revert'
I am unsure as to what is causing this error, the only thing that this seems to tell me is that it occurs in the 'deposit collateral' function of my handler. Can someone please help me understand where this error is?
Thank you very much in advance
Beta Was this translation helpful? Give feedback.
All reactions