Why we use chainlink-brownie-contracts but not download from Chainlink officially #1870
-
|
Hi all, I prefer to download it from official source, like imagine how to explain to your boss if you need to download something that is not official when security is important. However, when I search Chainlink doc, it seems that there is no solution for foundry, there is something called foundry-chainlink-toolkit in the doc however, it does not contain the contracts I want such as V3Aggregator. https://docs.chain.link/quickstarts/foundry-chainlink-toolkit. Can anyone explain this? Thanks! Btw another question, should this kind of question be put into Discussions or Issues? |
Beta Was this translation helpful? Give feedback.
Replies: 4 comments 10 replies
-
|
Hello @CH-coding-fire, This question is OK here in discussion. Honestly, I didn't even give it a second thought when Patrick instructed us to install that package as I believe, as far as smart contract security is concerned, Patrick knows more than I do, and I think that package should be a sub-package of chainlink but then, since you raised this question, let's wait for @PatrickAlphaC response and learn more together. |
Beta Was this translation helpful? Give feedback.
-
|
As I read the Github page of Chainlink brownie contract. It says this "This repository is a slimmed down version of Chainlink's official repo.... its a minimal repo that only copies the chainlink/contracts folder and updates it everyday.". I think if you go and compare both the official and the brownie versions you'll be able to figure out what difference there is. |
Beta Was this translation helpful? Give feedback.
-
|
Interesting |
Beta Was this translation helpful? Give feedback.
-
|
The belief that they are the same is based on we trust Patrick (the author) , but imagine how to explain that to your boss if it is real job? |
Beta Was this translation helpful? Give feedback.
-
|
Honestly, it isn't hard. You will go, |
Beta Was this translation helpful? Give feedback.
-
|
gm, happy to answer here!
That's not true. This is an official repo. The repository is owned and maintained by the chainlink team for this very purpose, and gets releases from the proper chainlink release process. You can see it's still the https://github.com/smartcontractkit/chainlink-brownie-contracts Let's talk about what "Official" meansThe "official" release process is that chainlink deploys it's packages to npm. So technically, even downloading directly from So, then you have two options:
Summary
Great question! And keep that skepticism - it'll treat you well. |
Beta Was this translation helpful? Give feedback.
-
|
This was very informative. IMO this should be added in the readme and visible to people to remove confusion. |
Beta Was this translation helpful? Give feedback.
-
|
Indeed |
Beta Was this translation helpful? Give feedback.
-
|
Good shout. Anyone care to open a PR for codebases they find this relevant for? |
Beta Was this translation helpful? Give feedback.
-
If no one else takes this, then I'll take it and will try to update it this weekend. Let me know if anything else is required. |
Beta Was this translation helpful? Give feedback.
-
|
I think that is what needed to be done. |
Beta Was this translation helpful? Give feedback.
-
|
I'll try to update this today. @PatrickAlphaC should I update the main cource page (Eg: this Foundry-Full-Course) or should I change individual projects that utilized brownie kit. Personnaly I think the later is a better options since this is where people will be coming again and again to but still want your advice. |
Beta Was this translation helpful? Give feedback.
-
|
Up to you, both are probably good! |
Beta Was this translation helpful? Give feedback.
gm, happy to answer here!
That's not true. This is an official repo. The repository is owned and maintained by the chainlink team for this very purpose, and gets releases from the proper chainlink release process. You can see it's still the
smartcontractkitorg as well.https://github.com/smartcontractkit/chainlink-brownie-contracts
Let's talk about what "Official" means
The "official" release process is that chainlink deploys it's packages to npm. So technically, even downloading directly from
smartcontractkit/chainlinkis wrong, because it could be using unreleased code.So, then you have two options: