Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some problems in license text extraction ignored. #228

Open
AugustusKling opened this issue Dec 9, 2024 · 2 comments
Open

[BUG] Some problems in license text extraction ignored. #228

AugustusKling opened this issue Dec 9, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@AugustusKling
Copy link
Contributor

Describe the bug

Some cases result in skipping over license files silently for the experimental license text extraction from #193

Make sure to abort with a non-zero status code on errors, that is address things like mentioned in https://github.com/AugustusKling/cyclonedx-node-yarn/pull/1/files#r1840859282

To Reproduce

Have a licence file with unknown MIME type in any dependency.

Expected behavior

Program should abort with a non-zero exit code.

@AugustusKling AugustusKling added the bug Something isn't working label Dec 9, 2024
@jkowalleck
Copy link
Member

@AugustusKling , is this something you want to work on?

An idea how to test this:
a dedicated test bed for this could include a license file that has no read-permissions. on linux/macos systems, this should be feasible.

@AugustusKling
Copy link
Contributor Author

I intend to follow-up this ticket with a PR to suggest some changes as time permits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants