Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize trivy plugin #3

Open
prabhu opened this issue Apr 28, 2023 · 1 comment
Open

Optimize trivy plugin #3

prabhu opened this issue Apr 28, 2023 · 1 comment

Comments

@prabhu
Copy link
Collaborator

prabhu commented Apr 28, 2023

We're stuck with trivy for a bit more time. The purpose of this ticket is to optimize and trim the size of the plugin.

Below is the main code
https://github.com/CycloneDX/cdxgen-plugins-bin/blob/main/thirdparty/trivy/main.go

While this imports all the commands, we only need two commands - image and rootfs. Even rootfs alone is enough since cdxgen could work with just that.

So perhaps a much simplified version of this code

https://github.com/aquasecurity/trivy/blob/main/pkg/commands/artifact/run.go#L197

@Preetam
Copy link

Preetam commented May 2, 2023

I think you can call https://github.com/aquasecurity/trivy/blob/1be1e2e6380efd9b63913721db1b9d61e3800126/pkg/commands/artifact/run.go#L404 with the flags you need.

The NewRootfsCommand function eventually calls

return artifact.Run(cmd.Context(), options, artifact.TargetRootfs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants