Add ability to control online players along with max players#36
Open
ChimneySwift wants to merge 1 commit into
Open
Add ability to control online players along with max players#36ChimneySwift wants to merge 1 commit into
ChimneySwift wants to merge 1 commit into
Conversation
jacoballen1
reviewed
Mar 9, 2021
Comment on lines
+2
to
+24
| * This file is part of Neutron, licensed under the MIT License | ||
| * | ||
| * Copyright (c) 2020 Crypnotic <crypnoticofficial@gmail.com> | ||
| * Copyright (c) 2020 Contributors | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| */ |
There was a problem hiding this comment.
Might I ask why the formatting was changed?
Author
There was a problem hiding this comment.
Yeah not sure, might have been my editor and I didn't realize until I submitted the PR (not super familiar with git).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds options to set online player counts, much like exists for the max player counts.
Adds the following settings:
I run a multi-proxy network (different geographic locations for each), previously each proxy's online player counts were constantly out of sync and didn't represent actual players on the network. For those in a similar situation (who don't have some kind of advanced multi-proxy system), the PING action would be quite useful.
The STATIC option I just implemented incase someone found it useful, and the CURRENT option mimics default behaviour.
Hopefully you can excuse git being strange with the header, not sure what happened there :>