Skip to content

Implement join and quit messages#18

Merged
Crypnotic merged 1 commit into
Crypnotic:masterfrom
N3FS:feature/connect-messages
Jun 1, 2019
Merged

Implement join and quit messages#18
Crypnotic merged 1 commit into
Crypnotic:masterfrom
N3FS:feature/connect-messages

Conversation

@mdcfe
Copy link
Copy Markdown
Contributor

@mdcfe mdcfe commented May 24, 2019

Implement join and quit messages:

  • The join and quit messages are defined in the locale
  • The permissions neutron.silentjoin and neutron.silentquit can be used to hide join and quit messages for a player if connectmessage.allow-silent-join-quit is set to true in the config

I've taken the locale code from CommandWrapper, but I think this should be moved to reside with the locale code itself rather than being duplicated here.

Feel free to push any changes here as needed.

@mdcfe mdcfe marked this pull request as ready for review May 27, 2019 09:32
@mdcfe mdcfe force-pushed the feature/connect-messages branch from 4d4adfe to a8124c6 Compare May 29, 2019 18:54
@Crypnotic
Copy link
Copy Markdown
Owner

Latest commit has the locale getMessage and message statically accessible in StringHelper

@mdcfe
Copy link
Copy Markdown
Contributor Author

mdcfe commented May 30, 2019

@Crypnotic The original commit was replaced with a8124c6 which uses StringHelper.

@Crypnotic
Copy link
Copy Markdown
Owner

@md678685 source.sendMessage(getMessage()) can be replaced with message() no?

@mdcfe
Copy link
Copy Markdown
Contributor Author

mdcfe commented May 31, 2019

@Crypnotic StringHelper doesn't have an equivalent for broadcast. I'll update #19 to use message though.

@Crypnotic
Copy link
Copy Markdown
Owner

I've added a StringHelper#broadcast that translates locale for each player based on the locale configuration, but I'll just merge and make a few changes that I would like to see that are based more on preference to keep you from having to do them

@Crypnotic Crypnotic merged commit c42e769 into Crypnotic:master Jun 1, 2019
dhiepp pushed a commit to dhiepp/Neutron that referenced this pull request Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants