You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ember.testing is a getter/setter in Ember, and destructuring like this will only read its value at the time the module is evaluated. In this case, Ember.testing will most likely be false when the module is evaluated, then change to trueduring the test. This behavior somewhat recently changed in emberjs/ember-test-helpers#227 (which is included in [email protected] / [email protected]).
I believe the fix here would be to remove the destructuring, and use Ember.testing directly inline.
Thanks a lot for this hint, we're currently working on version 1.0.0 using latest Ember with new modules API and hope to have import { isTesting, setTesting } from '@ember/test' available as soon as possible (ember-cli/ember-rfc176-data#12), then this issue should be gone anyways.
Ember.testing
is a getter/setter in Ember, and destructuring like this will only read its value at the time the module is evaluated. In this case,Ember.testing
will most likely befalse
when the module is evaluated, then change totrue
during the test. This behavior somewhat recently changed in emberjs/ember-test-helpers#227 (which is included in[email protected]
/[email protected]
).I believe the fix here would be to remove the destructuring, and use
Ember.testing
directly inline.ember-l10n/addon/services/l10n.js
Lines 4 to 17 in 256eb16
ember-l10n/addon/services/l10n.js
Lines 536 to 538 in 256eb16
The text was updated successfully, but these errors were encountered: