Fix Ord codegen to use other < self in reverse branch (#170)

The generated `Ord::cmp` for method-based `operator<` used
`other.<op>(other)` in its second branch, which can never evaluate true
and therefore suppresses `Ordering::Greater`. This change aligns that
branch with the intended reverse comparison (`other.<op>(self)`),
matching existing model-specific behavior.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: Copilot

cpp2rust/converter/converter.cpp

@@ -3685,7 +3685,7 @@ void Converter::ConvertOrdAndPartialOrdTraits(const clang::CXXRecordDecl *decl,
   case clang::OO_Less:
     if (clang::isa<clang::CXXMethodDecl>(op)) {
       first_branch = std::format("self.{}(other)", GetOverloadedOperator(op));
-      second_branch = std::format("other.{}(other)", GetOverloadedOperator(op));
+      second_branch = std::format("other.{}(self)", GetOverloadedOperator(op));
     } else {
       first_branch = std::format("{}(self, other)", GetOverloadedOperator(op));
       second_branch = std::format("{}(other, self)", GetOverloadedOperator(op));

tests/unit/out/unsafe/operator_less_than.rs

@@ -23,7 +23,7 @@ impl Ord for Pair {
         unsafe {
             if self.lt(other) {
                 std::cmp::Ordering::Less
-            } else if other.lt(other) {
+            } else if other.lt(self) {
                 std::cmp::Ordering::Greater
             } else {
                 std::cmp::Ordering::Equal
@@ -38,7 +38,7 @@ impl PartialOrd for Pair {
 }
 impl PartialEq for Pair {
     fn eq(&self, other: &Self) -> bool {
-        unsafe { !(self.lt(other)) && !(other.lt(other)) }
+        unsafe { !(self.lt(other)) && !(other.lt(self)) }
     }
 }
 impl Eq for Pair {}