Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postBuild file #35

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Add postBuild file #35

merged 2 commits into from
Mar 9, 2021

Conversation

sfarrens
Copy link
Member

@sfarrens sfarrens commented Mar 8, 2021 •
edited
Loading

@sfarrens sfarrens added the bug Something isn't working label Mar 8, 2021
@sfarrens sfarrens self-assigned this Mar 8, 2021
@sfarrens sfarrens requested a review from aboucaud March 8, 2021 16:13
@sfarrens sfarrens linked an issue Mar 8, 2021 that may be closed by this pull request
[Bug] shrbk not found on Binder #29
Open
aboucaud
aboucaud previously approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@aboucaud aboucaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Where did you put the file ?

I would recommend putting in a binder folder

@sfarrens
Copy link
Member Author

sfarrens commented Mar 8, 2021

Yep, good call. It is now in a binder directory.

@sfarrens
Copy link
Member Author

sfarrens commented Mar 9, 2021

@aboucaud can you formally click the approve button if you are happy with this? 😄

@sfarrens sfarrens merged commit 79d3946 into CosmoStat:develop Mar 9, 2021
@sfarrens sfarrens deleted the postbuild branch March 9, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aboucaud aboucaud aboucaud approved these changes

Assignees

@sfarrens sfarrens

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] shrbk not found on Binder
2 participants
@sfarrens @aboucaud