Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First implementation of KSB #47

Merged
merged 13 commits into from
May 7, 2021
Merged

First implementation of KSB #47

merged 13 commits into from
May 7, 2021

Conversation

fadinammour
Copy link

@fadinammour fadinammour commented Apr 9, 2021 •
edited
Loading

Added content about:

  • KSB
  • The relation between the lensing equation and reduced shear
  • weighted moments
  • Taylor series

To do:

  • move the part about the lensing equation and the reduced shear from KSB to Introduction.
  • add more plots to give more meaning to the formulas in KSB (use plots from papers and cite them).
  • add a practical example on how to use KSB with Galsim (code snippet).
  • mention KSB ameliorations and alternatives such as HSM, REGAUSS (used in HSC).

@sfarrens sfarrens added the enhancement New feature or request label Apr 9, 2021
@sfarrens sfarrens linked an issue Apr 9, 2021 that may be closed by this pull request
Add content to KSB #12
Open
3 tasks
@fadinammour
Copy link
Author

fadinammour commented May 1, 2021 •
edited
Loading

There are two things that need to be done:

  • citing the references correctly, for the paper and for the Taylor expansion notebook. I didn't find an example that I could copy.
  • Maybe giving a bit more details on HSM and REGAUSS. I don't really know how they are different from KSB.

@fadinammour fadinammour requested a review from sfarrens May 1, 2021 17:35
@thuiop
Copy link

thuiop commented May 6, 2021

For citing papers correctly, you should :

  • add the reference for the article in the Bibtex format in the corresponding file from shearbook/_bibliography (either z_moments.bib or z_moments_method.bib in your case)
  • Add {cite}`Sheldon2020` in your notebook where you want to reference it, replacing "Sheldon2020" by the name of the article in the bib file.

@sfarrens sfarrens merged commit 8ce404a into develop May 7, 2021
@sfarrens sfarrens deleted the viola2010 branch May 7, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfarrens sfarrens sfarrens approved these changes

Assignees

@fadinammour fadinammour

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add content to KSB
3 participants
@fadinammour @thuiop @sfarrens