Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Foundry version used to 1.0 #691

Open
3 of 7 tasks
kyzooghost opened this issue Feb 17, 2025 · 0 comments
Open
3 of 7 tasks

Update Foundry version used to 1.0 #691

kyzooghost opened this issue Feb 17, 2025 · 0 comments
Labels
Contracts Smart Contract related dependencies Pull requests that update a dependency file good first issue Good for newcomers P3: Low Issue priority: low

Comments

@kyzooghost
Copy link
Contributor

kyzooghost commented Feb 17, 2025

Motivation / Description

Update Foundry dependency to 1.0 to keep up to date with the latest release so that partners/auditors feedback loop is quick.

Tasks

  • Update foundry.toml file to use foundry_version = "stable" flag

Acceptance criteria

  • run-smc-tests.yml CI workflow should succeed

Risks

  • May break existing CI flow defined in run-smc-tests.yml
  • May break husky hooks on local developer machines (Foundry is an implicit dependency)

Remember to

  • Add the documentation label in case there is an impact on the documentation
  • Add priority and team labels
  • Add Task for updating the Runbook or adding/updating existing metrics and alerts.
@kyzooghost kyzooghost added Contracts Smart Contract related dependencies Pull requests that update a dependency file good first issue Good for newcomers P3: Low Issue priority: low labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contracts Smart Contract related dependencies Pull requests that update a dependency file good first issue Good for newcomers P3: Low Issue priority: low
Projects
None yet
Development

No branches or pull requests

1 participant