Merge pull request opensim-org#3235 from opensim-org/fix_delp1990-memleak

Patched memory leak in OpenSim::Delp1990Muscle_Deprecated

Author: adamkewley

OpenSim/Actuators/Delp1990Muscle_Deprecated.cpp

@@ -128,9 +128,17 @@ void Delp1990Muscle_Deprecated::copyData(const Delp1990Muscle_Deprecated &aMuscl
     _activation1 = aMuscle._activation1;
     _activation2 = aMuscle._activation2;
     _mass = aMuscle._mass;
+
+    delete _tendonForceLengthCurve;
     _tendonForceLengthCurve = (Function*)Object::SafeCopy(aMuscle._tendonForceLengthCurve);
+
+    delete _activeForceLengthCurve;
     _activeForceLengthCurve = (Function*)Object::SafeCopy(aMuscle._activeForceLengthCurve);
+
+    delete _passiveForceLengthCurve;
     _passiveForceLengthCurve = (Function*)Object::SafeCopy(aMuscle._passiveForceLengthCurve);
+
+    delete _forceVelocityCurve;
     _forceVelocityCurve = (Function*)Object::SafeCopy(aMuscle._forceVelocityCurve);
 }
 
@@ -428,7 +436,8 @@ Function* Delp1990Muscle_Deprecated::getActiveForceLengthCurve() const
  */
 bool Delp1990Muscle_Deprecated::setActiveForceLengthCurve(Function* aActiveForceLengthCurve)
 {
-    _activeForceLengthCurve = aActiveForceLengthCurve;
+    delete _activeForceLengthCurve;
+    _activeForceLengthCurve = aActiveForceLengthCurve->clone();
     return true;
 }
 
@@ -452,7 +461,8 @@ Function* Delp1990Muscle_Deprecated::getPassiveForceLengthCurve() const
  */
 bool Delp1990Muscle_Deprecated::setPassiveForceLengthCurve(Function* aPassiveForceLengthCurve)
 {
-    _passiveForceLengthCurve = aPassiveForceLengthCurve;
+    delete _passiveForceLengthCurve;
+    _passiveForceLengthCurve = aPassiveForceLengthCurve->clone();
     return true;
 }
 
@@ -476,7 +486,8 @@ Function* Delp1990Muscle_Deprecated::getTendonForceLengthCurve() const
  */
 bool Delp1990Muscle_Deprecated::setTendonForceLengthCurve(Function* aTendonForceLengthCurve)
 {
-    _tendonForceLengthCurve = aTendonForceLengthCurve;
+    delete _tendonForceLengthCurve;
+    _tendonForceLengthCurve = aTendonForceLengthCurve->clone();
     return true;
 }
 
@@ -500,7 +511,8 @@ Function* Delp1990Muscle_Deprecated::getForceVelocityCurve() const
  */
 bool Delp1990Muscle_Deprecated::setForceVelocityCurve(Function* aForceVelocityCurve)
 {
-    _forceVelocityCurve = aForceVelocityCurve;
+    delete _forceVelocityCurve;
+    _forceVelocityCurve = aForceVelocityCurve->clone();
     return true;
 }