Communicate through swig that PathPointSet::insert takes ownership (opensim-org#3276)

* Communicate through swig that PathPointSet::insert takes ownership of the passed in pointer

* Update java_simulation.i

Beef up the comment explaining the change

* Update CHANGELOG.md

Update changelog

Author: aymanhab

Bindings/Java/swig/java_simulation.i

@@ -31,6 +31,16 @@ using namespace SimTK;
 
 %rename OpenSim::PathPointSet::clone unused_clone;
 
+// replace insert with a variant that takes ownership of passed in AbstractPathPoint.
+// in java the method 'insert' ends in super class so we can call it internally
+// and that hides the super class method 
+%typemap(javacode) OpenSim::PathPointSet %{
+    public boolean insert(int aIndex, AbstractPathPoint aObject) {
+       aObject.markAdopted();
+       return super.insert(aIndex, aObject);
+   }
+%}
+
 %extend OpenSim::Body {
     void getInertia(Array<double>& rInertia) {
         SimTK::Mat33 inertia= self->getInertia().toMat33();

Bindings/Python/swig/python_simulation.i

@@ -92,6 +92,10 @@ MODEL_ADOPT_HELPER(Controller);
     args[1]._markAdopted()
 %}
 
+// PathPointSet takes ownership of passed in object
+%pythonappend OpenSim::PathPointSet::insert %{
+    aObject._markAdopted()
+%}
 // Typemaps
 // ========
 // None.

CHANGELOG.md

@@ -10,6 +10,7 @@ v4.4.1
 ======
 
 - Made `Component::getSocketNames` a `const` member method (previously: non-const)
+- Modifed the swig interface files to make OpenSim::PathPointSet adopt new PathPoints inserted into it. (Issue #3276)
 
 v4.4
 ====