From 6c13cb5409020820f0272027eca6598ee6dfc0de Mon Sep 17 00:00:00 2001
From: Youssef Victor <youssefvictor00@gmail.com>
Date: Thu, 12 Dec 2024 06:07:17 +0100
Subject: [PATCH 1/2] More tests for semi auto prop analyzer
---
...ablePropertyOnSemiAutoPropertyCodeFixer.cs | 114 ++++++++++++++++++
1 file changed, 114 insertions(+)
diff --git a/tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs b/tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs
index e9cccaa9..fb48a92a 100644
--- a/tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs
+++ b/tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs
@@ -74,6 +74,120 @@ public partial class SampleViewModel : ObservableObject
await test.RunAsync();
}
+ [TestMethod]
+ public async Task SimplePropertyWithBlockAccessorSyntax()
+ {
+ string original = """
+ using CommunityToolkit.Mvvm.ComponentModel;
+
+ namespace MyApp;
+
+ public class SampleViewModel : ObservableObject
+ {
+ public string Name
+ {
+ get
+ {
+ return field;
+ }
+ set => SetProperty(ref field, value);
+ }
+ }
+ """;
+
+ string @fixed = """
+ using CommunityToolkit.Mvvm.ComponentModel;
+
+ namespace MyApp;
+
+ public partial class SampleViewModel : ObservableObject
+ {
+ [ObservableProperty]
+ public partial string Name { get; set; }
+ }
+ """;
+
+ CSharpCodeFixTest test = new(LanguageVersion.Preview)
+ {
+ TestCode = original,
+ FixedCode = @fixed,
+ ReferenceAssemblies = ReferenceAssemblies.Net.Net80,
+ };
+
+ test.TestState.AdditionalReferences.Add(typeof(ObservableObject).Assembly);
+ test.ExpectedDiagnostics.AddRange(new[]
+ {
+ // /0/Test0.cs(7,19): info MVVMTK0056: The semi-auto property MyApp.SampleViewModel.Name can be converted to a partial property using [ObservableProperty], which is recommended (doing so makes the code less verbose and results in more optimized code)
+ CSharpCodeFixVerifier.Diagnostic().WithSpan(7, 19, 7, 23).WithArguments("MyApp.SampleViewModel", "Name"),
+ });
+
+ test.FixedState.ExpectedDiagnostics.AddRange(new[]
+ {
+ // /0/Test0.cs(8,27): error CS9248: Partial property 'SampleViewModel.Name' must have an implementation part.
+ DiagnosticResult.CompilerError("CS9248").WithSpan(8, 27, 8, 31).WithArguments("MyApp.SampleViewModel.Name"),
+ });
+
+ await test.RunAsync();
+ }
+
+ [TestMethod]
+ public async Task SimplePropertyWithNestedBlockSyntax()
+ {
+ string original = """
+ using CommunityToolkit.Mvvm.ComponentModel;
+
+ namespace MyApp;
+
+ public class SampleViewModel : ObservableObject
+ {
+ public string Name
+ {
+ get
+ {
+ {
+ return field;
+ }
+ }
+ set => SetProperty(ref field, value);
+ }
+ }
+ """;
+
+ string @fixed = """
+ using CommunityToolkit.Mvvm.ComponentModel;
+
+ namespace MyApp;
+
+ public partial class SampleViewModel : ObservableObject
+ {
+ [ObservableProperty]
+ public partial string Name { get; set; }
+ }
+ """;
+
+ CSharpCodeFixTest test = new(LanguageVersion.Preview)
+ {
+ TestCode = original,
+ FixedCode = @fixed,
+ ReferenceAssemblies = ReferenceAssemblies.Net.Net80,
+ };
+
+ test.TestState.AdditionalReferences.Add(typeof(ObservableObject).Assembly);
+ test.ExpectedDiagnostics.AddRange(new[]
+ {
+ // /0/Test0.cs(7,19): info MVVMTK0056: The semi-auto property MyApp.SampleViewModel.Name can be converted to a partial property using [ObservableProperty], which is recommended (doing so makes the code less verbose and results in more optimized code)
+ CSharpCodeFixVerifier.Diagnostic().WithSpan(7, 19, 7, 23).WithArguments("MyApp.SampleViewModel", "Name"),
+ });
+
+ test.FixedState.ExpectedDiagnostics.AddRange(new[]
+ {
+ // /0/Test0.cs(8,27): error CS9248: Partial property 'SampleViewModel.Name' must have an implementation part.
+ DiagnosticResult.CompilerError("CS9248").WithSpan(8, 27, 8, 31).WithArguments("MyApp.SampleViewModel.Name"),
+ });
+
+ await test.RunAsync();
+ }
+
[TestMethod]
public async Task SimpleProperty_WithSemicolonTokenGetAccessor()
{
From 2a0e58414c7b6af0291fb94d96cc81fc3cbeaf1e Mon Sep 17 00:00:00 2001
From: Youssef Victor <youssefvictor00@gmail.com>
Date: Thu, 12 Dec 2024 06:11:31 +0100
Subject: [PATCH 2/2] Update
Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs
---
.../Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs b/tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs
index fb48a92a..bc2c589f 100644
--- a/tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs
+++ b/tests/CommunityToolkit.Mvvm.SourceGenerators.Roslyn4120.UnitTests/Test_UseObservablePropertyOnSemiAutoPropertyCodeFixer.cs
@@ -90,7 +90,10 @@ public string Name
{
return field;
}
- set => SetProperty(ref field, value);
+ set
+ {
+ SetProperty(ref field, value);
+ }
}
}
""";