Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource relationships for SQL database projects #502

Open
jmezach opened this issue Feb 25, 2025 · 3 comments
Open

Add resource relationships for SQL database projects #502

jmezach opened this issue Feb 25, 2025 · 3 comments
Assignees

Comments

@jmezach
Copy link
Contributor

jmezach commented Feb 25, 2025

Related to an existing integration?

Yes

Existing integration

SqlDatabaseProjects

Overview

With .NET Aspire 9.1 releasing I was wondering if we should add the new relationships to the SQL database projects resources so that could become nested under the server resource in the dashboard. Haven’t looked yet at what would be required but should be fairly simple.

Usage example

I don’t think this would require new public API’s. Technically the relationship is already there, we just don’t model it currently

Breaking change?

No

Alternatives

I guess we could just not do it, but I think it makes sense and removes a fair amount of clutter for folks with many database projects being deployed to the same server.

Additional context

@ErikEJ Any thoughts?

Help us help you

Yes, I'd like to be assigned to work on this item

@jmezach jmezach self-assigned this Feb 25, 2025
@ErikEJ
Copy link
Contributor

ErikEJ commented Feb 25, 2025

Great addition, just read about it in the release notes (Postgress databases under a server)

@aaronpowell
Copy link
Member

Yep, and it looks like we need to do a bit of a review of how the dependency/waiting happens too, especially in tests (I had to disable a test for the release).

My understanding is that if you configure relationships you get an implicit set of "wait for" behaviour, so we can possibly leverage that. This is why a child resource (eg, a database) doesn't need a WaitFor on the parent (eg: db server).

@davidfowl
Copy link
Contributor

The relationships are visual only. IResourceWithPatent behavior should not have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants