Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement resilience for OllamaSharp integration #474

Open
aaronpowell opened this issue Feb 17, 2025 · 0 comments · May be fixed by #534
Open

Implement resilience for OllamaSharp integration #474

aaronpowell opened this issue Feb 17, 2025 · 0 comments · May be fixed by #534
Assignees
@aaronpowell
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
9.3

Comments

@aaronpowell
Copy link
Member

I don't have a strong opinion on if ollamasharp should built in resiliency, I do care that the aspire integration does. AFAIK the constructor already supports an HttpClient so this is what I did:

https://github.com/davidfowl/aspire-ai-chat-demo/blob/1779a65d4d93b52be102758f188b2581fd0348fe/ChatApi/ChatClientExtensions.cs#L38-L49

Which turns out to be pretty required when you run on underpowered devices.

Originally posted by @davidfowl in #461
@aaronpowell aaronpowell added enhancement New feature or request good first issue Good for newcomers labels Feb 17, 2025
@aaronpowell aaronpowell added this to the 9.3 milestone Mar 5, 2025
@aaronpowell aaronpowell self-assigned this Mar 6, 2025
aaronpowell added a commit that referenced this issue Mar 6, 2025
@aaronpowell
Using the built-in method to register a HttpClient in .NET for Ollama…
e3f59b9 
…Sharp

This means that we can leverage the configurations applied to HttpClient via ServiceDefault around stuff like resiliancy, rather than creating a HttpClient in isolation that is not aware of any of that configuration.

No new tests are added as there's not we could easily test with this, but all existing tests should continue to pass

Fixes #474
@aaronpowell aaronpowell linked a pull request Mar 6, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronpowell aaronpowell

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
9.3
Development

Successfully merging a pull request may close this issue.

Using the built-in method to register a HttpClient in .NET for OllamaSharp CommunityToolkit/Aspire
1 participant
@aaronpowell