Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Windows app goes off screen sometimes #849

Closed
robinjhuang opened this issue Feb 6, 2025 · 2 comments · May be fixed by #850
Closed

[Bug] Windows app goes off screen sometimes #849

robinjhuang opened this issue Feb 6, 2025 · 2 comments · May be fixed by #850
Labels
bug Something isn't working

Comments

@robinjhuang
Copy link
Member

robinjhuang commented Feb 6, 2025

Recording.2025-02-06.141649.mp4

Potential solution is to just reset the app location when opening it.

┆Issue is synchronized with this Notion page by Unito

@robinjhuang robinjhuang added the bug Something isn't working label Feb 6, 2025
@webfiltered
Copy link
Contributor

Potential solution is to just reset the app location when opening it.

If that's the plan, we should just remove the window position save/restore code entirely - let the native window manager do its job.

But as this can be a very user-friendly feature - always restoring the window to the right position - I would say we simply mimic WM behaviour. On window create:

  1. If size > available (screen) size, shrink
  2. If window rect is not contained by available rect, reposition until it is

@yoland68
Copy link
Member

yoland68 commented Feb 7, 2025

I just landed this: #848
Thought it was small enough to just push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants