Repository navigation
fix(workflow): persist Cloud sidebar files and verify save identity - #1046
Draft
wealthwiselabs wants to merge 1 commit into
Draft
wealthwiselabs wants to merge 1 commit into
wealthwiselabs wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comfy workflow save --where cloudcreated a workflow record without the userdata file listed by the Cloud sidebar. Save now writesworkflows/<name>.jsonand returns a record ID only after unique-name and matching-content read-back. A failed/stale mirror leaves the successful file save intact with an explicit null-ID warning.--no-overwrite; documents same-name replacement and the ignored description field. Hidden names and the favorites index are refused.Backend behavior was checked read-only against the userdata and workflow service implementations. Tests cover save/list/get/delete, stale mirroring, duplicate names, another member's record, and partial failure. No live Cloud writes were performed. Filename association and deletion remain separate API calls; the backend has no atomic conditional-delete operation.
Validation
git diff --checkpass.Related skill: #1008. This fix is independent and targets
main.