Skip to content

fix(workflow): persist Cloud sidebar files and verify save identity - #1046

Draft
wealthwiselabs wants to merge 1 commit into
mainfrom
esun/fix/workflow-save-sidebar
Draft

wealthwiselabs wants to merge 1 commit into
mainfrom
esun/fix/workflow-save-sidebar

Conversation

@wealthwiselabs

Copy link
Copy Markdown

comfy workflow save --where cloud created a workflow record without the userdata file listed by the Cloud sidebar. Save now writes workflows/<name>.json and returns a record ID only after unique-name and matching-content read-back. A failed/stale mirror leaves the successful file save intact with an explicit null-ID warning.

  • Adds --no-overwrite; documents same-name replacement and the ignored description field. Hidden names and the favorites index are refused.
  • Deletion removes both file and record only after unique association, content and authenticated ownership checks; ambiguous associations remain untouched and partial cleanup is actionable.
  • Does not invent a private workflow deep link. The saved file opens through the Cloud Workflows sidebar.

Backend behavior was checked read-only against the userdata and workflow service implementations. Tests cover save/list/get/delete, stale mirroring, duplicate names, another member's record, and partial failure. No live Cloud writes were performed. Filename association and deletion remain separate API calls; the backend has no atomic conditional-delete operation.

Validation

  • 207 focused tests passed on the rebased branch, including error-code registry and command-reference guards. Full Ruff lint/format checks and git diff --check pass.
  • Companion fixes and the Run on Cloud skill passed 1,934 affected tests together before this rebase.
  • The earlier broad-suite snapshot was not clean: 10,297 passed, 16 skipped, 56 failed. Two stale discovery assertions were corrected and pass. Remaining failures include existing tests that read a live localhost ComfyUI catalog and previously known dependency-version/certificate cases. Representative catalog failures reproduce on clean main. No clean full-suite or live Cloud acceptance claim.

Related skill: #1008. This fix is independent and targets main.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants