Skip to content

fix(discovery): report Desktop installs and missing workspaces - #1043

Draft
wealthwiselabs wants to merge 2 commits into
mainfrom
esun/fix/which-desktop-install
Draft

wealthwiselabs wants to merge 2 commits into
mainfrom
esun/fix/which-desktop-install

Conversation

@wealthwiselabs

Copy link
Copy Markdown

comfy which could report a nonexistent default workspace with success on Comfy Desktop 2, whose code, data and model roots are split. It now reports an existing Desktop checkout and its split paths, or workspace_not_found; comfy env includes existence and actionable configuration warnings.

Discovery preserves explicit workspace selection and does not silently change launch/install routing. Malformed configuration and invalid launch timestamps are handled, and adopted installs with an inferred data root are marked unverified.

Focused validation covers Desktop detection, which/env, workspace selection and manager reporting.

Validation

  • 229 focused tests passed on the rebased branch, including error-code registry and command-reference guards. Full Ruff lint/format checks and git diff --check pass.
  • Companion fixes and the Run on Cloud skill passed 1,934 affected tests together before this rebase.
  • The earlier broad-suite snapshot was not clean: 10,297 passed, 16 skipped, 56 failed. Two stale discovery assertions were corrected and pass. Remaining failures include existing tests that read a live localhost ComfyUI catalog and previously known dependency-version/certificate cases. Representative catalog failures reproduce on clean main. No clean full-suite or live Cloud acceptance claim.

Related skill: #1008. This fix is independent and targets main.

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants