Repository navigation
fix(discovery): report Desktop installs and missing workspaces - #1043
Draft
wealthwiselabs wants to merge 2 commits into
Draft
wealthwiselabs wants to merge 2 commits into
wealthwiselabs wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comfy whichcould report a nonexistent default workspace with success on Comfy Desktop 2, whose code, data and model roots are split. It now reports an existing Desktop checkout and its split paths, orworkspace_not_found;comfy envincludes existence and actionable configuration warnings.Discovery preserves explicit workspace selection and does not silently change launch/install routing. Malformed configuration and invalid launch timestamps are handled, and adopted installs with an inferred data root are marked unverified.
Focused validation covers Desktop detection, which/env, workspace selection and manager reporting.
Validation
git diff --checkpass.Related skill: #1008. This fix is independent and targets
main.