Skip to content

docs(skills): uploaded audio and video load on cloud - #1040

Open
wealthwiselabs wants to merge 1 commit into
mainfrom
esun/docs/cloud-media-uploads
Open

wealthwiselabs wants to merge 1 commit into
mainfrom
esun/docs/cloud-media-uploads

Conversation

@wealthwiselabs

Copy link
Copy Markdown

ELI5

The agent instructions told agents that Comfy Cloud can't use audio or video files you upload, so they built workarounds for a limit that no longer exists. This corrects the instructions.

Motivation

The comfy and comfy-director skills say cloud LoadAudio is blind to uploads and that uploaded videos are not catalogued for LoadVideo, steering agents to generate audio in-graph or assemble video locally. A test today shows both upload paths work, so the guidance costs agents extra work and wrongly rules out workflows that take a video or audio input.

Provenance

  • Authored by: interactive session
  • Verified:
    • Live test: uploaded a 2 s mp4 and a 2 s wav with comfy upload --where cloud; a LoadVideo → GetVideoComponents → PreviewImage job and a LoadAudio → PreviewAudio job each completed using the uploaded cloud_name
    • Tests: tests/comfy_cli/skills + test_command_mentions.py green (119 passed); ruff format --check clean
    • Not run locally: full suite (docs-only change), CI matrix
    • Not checked: whether uploads appear in the loaders' dropdown choices (the nodes show lookup failed during the test)

Reviewer context

  • Type: docs fix — skill text only

Summary

  • comfy skill, Audio gotchas: replace "Cloud can't load uploaded audio" with the upload → cloud_name flow.
  • comfy skill, multi-stage orchestration: drop the "videos not yet catalogued for LoadVideo" limit.
  • comfy-director: same correction in the dialogue bullet.

Test plan

  • comfy upload clip.mp4 --where cloud, run a LoadVideo graph with the returned cloud_name
  • Same for a .wav with LoadAudio

LoadAudio and LoadVideo on Comfy Cloud load an uploaded file by its
cloud_name. A 2026-10-20 test uploaded a 2 s mp4 and a 2 s wav with
`comfy upload --where cloud`; a LoadVideo job and a LoadAudio job each
completed with the file. Drop the claims that cloud cannot see uploaded
audio or video.
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f8dabba3-c000-4583-87cc-249989af3713
📥 Commits

Reviewing files that changed from the base of the PR and between a9c5e20 and ace8e75.

📒 Files selected for processing: 2
  • comfy_cli/skills/comfy-director/SKILL.md
  • comfy_cli/skills/comfy/SKILL.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The skill documentation now explains how to load uploaded audio and video in cloud workflows. It also says to wire audio generated in the same job directly when possible.

Changes: Cloud media loading guidance

Layer / File(s) Summary
Document cloud media loading
comfy_cli/skills/comfy/SKILL.md, comfy_cli/skills/comfy-director/SKILL.md
The guidance explains that LoadAudio and LoadVideo can use uploaded media’s cloud_name. It also recommends direct wiring for audio generated in the same job.

Suggested reviewers: skishore23

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to ace8e

The documented cloud media workflows align with the available implementation and reported tests.

Architecture risk: 🔵 Low · up to ace8e

The change affects 1 system.

Changed systems: comfy_cli

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — comfy_cli (service) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in comfy_cli/skills/comfy-director/SKILL.md: Updated the audio-loading guidance: same-job audio is wired by connection, while uploaded stems are loaded by LoadAudio via cloud_name; the previous restriction against uploaded cloud audio was removed.
  • observed — Modified behavior in comfy_cli/skills/comfy/SKILL.md: Replaced the warning that cloud LoadAudio cannot use uploaded files with instructions to upload audio, pass its cloud_name to LoadAudio, and prefer direct in-graph audio wiring for same-job generation.
  • observed — Modified behavior in comfy_cli/skills/comfy/SKILL.md: Replaced the cloud limitation on uploaded videos with the rule that LoadVideo accepts an uploaded video's cloud_name, like LoadImage accepts uploaded images.
Pre-merge checks: Passed 2
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@wealthwiselabs

Copy link
Copy Markdown
Author

@skishore23 - my agent tested the video and audio upload fxn for cli, they worked. looks like our docs are out of date. submit a pr to fix it

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants