Repository navigation
feat(run): add --client-id so a run can submit as an already-connected client #1314
Workflow file for this run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Description: Thin caller for the shared public-repo-hygiene reusable workflow | |
| # in Comfy-Org/github-workflows, which owns the checker AND its known-public | |
| # allowlist. This replaces the in-tree copy this repo used to carry. | |
| # | |
| # Why the checker is not in this repo any more: the old job ran | |
| # the checker straight out of the PR's own checkout, so a PR could widen the | |
| # allowlist — or disable the scan — and go green. The reusable loads the | |
| # checker from the pinned `workflows_ref` commit instead, so a PR here cannot | |
| # reach it through this workflow's inputs. The allowlist is deliberately NOT | |
| # an input, for the same reason. | |
| # | |
| # The pin is kept fresh by bump-public-repo-hygiene-callers.yml once this repo | |
| # is enrolled in the PUBLIC_REPO_HYGIENE_CALLERS roster. | |
| name: Public Repo Hygiene | |
| on: | |
| pull_request: | |
| push: | |
| branches: [main] | |
| jobs: | |
| hygiene: | |
| permissions: | |
| contents: read | |
| uses: Comfy-Org/github-workflows/.github/workflows/public-repo-hygiene.yml@3b2c8ca1f52056b54453a659fdb4473cfc88aa0e # github-workflows main (3b2c8ca) | |
| with: | |
| # REQUIRED, and must equal the `uses:` SHA above — the reusable asserts | |
| # they match, which is what pins the checker to the reviewed commit. | |
| workflows_ref: 3b2c8ca1f52056b54453a659fdb4473cfc88aa0e | |
| # `HAILUO-03` is MiniMax's Hailuo 03 model, named in the curated | |
| # knowledge bundle and asserted in tests. It is a product name that | |
| # happens to match the ticket-ID shape, not an internal reference. | |
| # `HALO-03` is a fictional product id used as test fixture data in | |
| # tests/comfy_cli/test_knowledge.py and test_knowledge_attach.py — not a | |
| # real ticket. | |
| # `ADR-032` names an Architecture Decision Record filename in the | |
| # public comfy-multi-player repo, referenced from | |
| # docs/op-vocabulary-v1.md and workflow_ops.py while documenting the | |
| # set_node_field op proposal's prior art (the withdrawn, title-only | |
| # set_title prototype that ADR-032 originally recorded, since | |
| # generalized and merged there as PR #235). It fits the ticket-ID shape | |
| # but is a public doc filename, not an internal ticket. | |
| ticket_allowlist: HAILUO-03,HALO-03,ADR-032 | |
| # One `exclude_paths:` entry, and the bar it had to clear is recorded here | |
| # because the entry is permanent. Every entry this caller used to carry | |
| # was a false positive in the checker itself — Hugging Face model URLs and | |
| # HF `owner/name` model repos read as unlisted GitHub repos — and all of | |
| # them are fixed upstream as of the pin above; the last one, | |
| # `.github/workflows/refresh-cql-catalogs.yml`, went away when that file | |
| # stopped naming its private source. An exclusion suppresses the scan for | |
| # a path forever, including content not yet written, so the bar is that | |
| # the finding is unfixable both here and upstream. | |
| # | |
| # `comfy_cli/command/generate/spec/openapi.yml` clears it. It is not | |
| # source: it is the response body of `https://api.comfy.org/openapi` | |
| # plus the one trailing newline `end-of-file-fixer` requires, so that a | |
| # refresh is a reproducible `curl` rather than a hand-edit (see the module | |
| # docstring in `comfy_cli/command/generate/spec.py`, which also carries the | |
| # newline-aware command that compares the two). Nobody writes into it, and | |
| # redacting the eight tokens the checker flags — six ticket-shaped ids | |
| # written into upstream `description` prose, none of them under a | |
| # `/proxy/` path this CLI surfaces, plus two hits on an IETF language-tag | |
| # standard that is a plain false positive — would silently fork the | |
| # vendored copy from the upstream document and make `curl … | cmp` stop | |
| # being the way to verify it. Unfixable here. Upstream is a different | |
| # repo, and api.comfy.org already serves every one of those ids publicly | |
| # to any unauthenticated caller, so vendoring them discloses nothing that | |
| # was not already published. Exact file, not a subtree: nothing else | |
| # under `spec/` is covered, and a second vendored artifact would need its | |
| # own entry and its own justification. | |
| exclude_paths: comfy_cli/command/generate/spec/openapi.yml |