From d832a623225623814726ac6436bb21e778a09e08 Mon Sep 17 00:00:00 2001 From: DrJKL Date: Wed, 17 Sep 2025 10:25:42 -0700 Subject: [PATCH 1/9] lint: adding attribute checking to the i18n vue checker --- eslint.config.ts | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/eslint.config.ts b/eslint.config.ts index 46a3d94d28..25a0cd1b62 100644 --- a/eslint.config.ts +++ b/eslint.config.ts @@ -191,6 +191,17 @@ export default defineConfig([ '@intlify/vue-i18n/no-raw-text': [ 'error', { + attributes: { + '/.+/': [ + 'aria-label', + 'aria-placeholder', + 'aria-roledescription', + 'aria-valuetext', + 'title' + ], + input: ['placeholder'], + img: ['alt'] + }, // Ignore strings that are: // 1. Less than 2 characters // 2. Only symbols/numbers/whitespace (no letters) From 14e37762dc5fb1215d363161a7493d6b295f41d5 Mon Sep 17 00:00:00 2001 From: DrJKL Date: Wed, 17 Sep 2025 10:49:40 -0700 Subject: [PATCH 2/9] lint: Don't limit placeholder to catch Component instances --- eslint.config.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eslint.config.ts b/eslint.config.ts index 25a0cd1b62..25353eff78 100644 --- a/eslint.config.ts +++ b/eslint.config.ts @@ -197,9 +197,9 @@ export default defineConfig([ 'aria-placeholder', 'aria-roledescription', 'aria-valuetext', - 'title' + 'title', + 'placeholder' ], - input: ['placeholder'], img: ['alt'] }, // Ignore strings that are: From 963c32b1ff79318bbeb1bc567e734ff5abf21297 Mon Sep 17 00:00:00 2001 From: Alexander Brown Date: Wed, 17 Sep 2025 23:29:15 -0700 Subject: [PATCH 3/9] lint: add label as a checked attribute. --- eslint.config.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/eslint.config.ts b/eslint.config.ts index 25353eff78..6ec128a849 100644 --- a/eslint.config.ts +++ b/eslint.config.ts @@ -197,8 +197,9 @@ export default defineConfig([ 'aria-placeholder', 'aria-roledescription', 'aria-valuetext', - 'title', - 'placeholder' + 'label', + 'placeholder', + 'title' ], img: ['alt'] }, From f04f2c15f8034f6864e9e18e7ba172d6463fe7ad Mon Sep 17 00:00:00 2001 From: Alexander Brown Date: Mon, 20 Oct 2025 15:49:45 -0700 Subject: [PATCH 4/9] lint: Add 'v-tooltip' to i18n checks --- eslint.config.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/eslint.config.ts b/eslint.config.ts index 6ec128a849..bd61ee934d 100644 --- a/eslint.config.ts +++ b/eslint.config.ts @@ -199,7 +199,8 @@ export default defineConfig([ 'aria-valuetext', 'label', 'placeholder', - 'title' + 'title', + 'v-tooltip' ], img: ['alt'] }, From 4ac8161fd7111abe74be13fe9d496a3393f38c3a Mon Sep 17 00:00:00 2001 From: DrJKL Date: Mon, 24 Nov 2025 14:49:35 -0800 Subject: [PATCH 5/9] i18n: fix remaining existing violations --- eslint.config.ts | 27 ++++++++++--------- .../maskeditor/BrushSettingsPanel.vue | 2 +- .../queue/CompletionSummaryBanner.vue | 6 ++++- src/components/widget/SampleModelSelector.vue | 10 +++---- src/locales/en/main.json | 13 ++++++++- src/platform/assets/components/AssetGrid.vue | 2 +- .../assets/components/MediaAssetMoreMenu.vue | 18 ++++++++----- .../cloud/onboarding/CloudSurveyView.vue | 22 ++++++++------- .../cloud/onboarding/components/CloudLogo.vue | 2 +- .../components/audio/AudioPreviewPlayer.vue | 6 ++--- .../form/dropdown/FormDropdownMenu.vue | 2 +- .../form/dropdown/FormDropdownMenuActions.vue | 2 +- .../components/ManagerProgressFooter.vue | 2 +- 13 files changed, 70 insertions(+), 44 deletions(-) diff --git a/eslint.config.ts b/eslint.config.ts index bd61ee934d..a720bb00a9 100644 --- a/eslint.config.ts +++ b/eslint.config.ts @@ -213,24 +213,27 @@ export default defineConfig([ ignoreNodes: ['md-icon', 'v-icon', 'pre', 'code', 'script', 'style'], // Brand names and technical terms that shouldn't be translated ignoreText: [ - 'ComfyUI', - 'GitHub', - 'OpenAI', 'API', - 'URL', - 'JSON', - 'YAML', - 'GPU', + 'App Data:', + 'App Path:', + 'ComfyUI', 'CPU', - 'RAM', + 'fps', 'GB', - 'MB', + 'GitHub', + 'GPU', + 'JSON', 'KB', + 'LoRA', + 'MB', 'ms', - 'fps', + 'OpenAI', + 'png', 'px', - 'App Data:', - 'App Path:' + 'RAM', + 'URL', + 'YAML', + '1.2 MB' ] } ] diff --git a/src/components/maskeditor/BrushSettingsPanel.vue b/src/components/maskeditor/BrushSettingsPanel.vue index 7f81359fc3..a43707ac1f 100644 --- a/src/components/maskeditor/BrushSettingsPanel.vue +++ b/src/components/maskeditor/BrushSettingsPanel.vue @@ -80,7 +80,7 @@ /> - preview + diff --git a/src/components/widget/SampleModelSelector.vue b/src/components/widget/SampleModelSelector.vue index 3f06ce2772..7f0147a3b8 100644 --- a/src/components/widget/SampleModelSelector.vue +++ b/src/components/widget/SampleModelSelector.vue @@ -30,7 +30,7 @@