Skip to content

Commit 6f1520d

Browse files
christian-byrnearjansingh
authored andcommitted
[bugfix] Fix update-playwright-expectations workflow missing frontend build (#6005)
## Problem The `update-playwright-expectations.yaml` workflow was failing with: ``` error: argument --front-end-root: The path '../dist' does not exist. ``` This was happening because the workflow was trying to launch the ComfyUI server with `--front-end-root ../dist` before building the frontend. ## Root Cause The workflow was missing the frontend build step entirely. It went directly from checkout → setup server with `launch_server: true` → run tests, skipping the crucial frontend build. ## Solution 1. Remove `launch_server: true` from `setup-comfyui-server` action call 2. Add `setup-frontend` action with `include_build_step: true` to build the frontend 3. Add separate "Launch ComfyUI Server" step that runs AFTER frontend is built This ensures the `dist/` directory exists before the server tries to use it. ## Testing This fixes errors seen on PR #5863 and any PR using the `/update-playwright` comment trigger. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6005-bugfix-Fix-update-playwright-expectations-workflow-missing-frontend-build-2876d73d36508182bb1af1123f3b2a87) by [Unito](https://www.unito.io)
1 parent 5c4be88 commit 6f1520d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.github/workflows/update-playwright-expectations.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ jobs:
5555
uses: actions/checkout@v5
5656
with:
5757
ref: ${{ steps.get-branch.outputs.branch }}
58+
- name: Setup Frontend
59+
uses: ./.github/actions/setup-frontend
60+
with:
61+
include_build_step: true
5862
- name: Setup ComfyUI Server
5963
uses: ./.github/actions/setup-comfyui-server
6064
with:

0 commit comments

Comments
 (0)