-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request - Plax CLI should error out if you send a Plaxt test request without supplying all the parameters required in a test #70
Comments
The commit referenced above includes some explanatory comments. When doing string-based substitutions, an unbound var should (at least in conventional settings) result in an error. The pending PR #64 works this way, and the commit above adds an explicit unit test. Note that in the context of a |
Maybe not -- unless We ran into recv:
regexp: param {FOO}={?P<BAR>.*} that was attempting to parse lines like Probably should re-open so that an unbound var in a regular expression in a |
Possible work-around, which might even be the right approach: Use blackslashes to escape the braces in the regular expression: recv:
regexp: param \{FOO\}={?P<BAR>.*}` Should consider supporting brace escapes outside of regular expressions. |
Plax should return an error if a plax test contains variables that are not defined / supplied in the plax test run command.
For example, a test may contain a section like this:
If you then send the plax test run command without supplying those variables, the test currently runs and fails without an error explaining that those variables weren't defined.
Bad request that should produce an error:
plax -test get-account.yaml -p '?!HOSTANDPORT=http://localhost:9090' -log debug
Properly formatted request:
plax -test get-account.yaml -p '?!HOSTANDPORT=http://localhost:9090' -p '?!ACCOUNTID'='12345abcde' -p '?!USERID'='test-users' -log debug
The text was updated successfully, but these errors were encountered: