feat: use given short_label in reaction (#2970)

Author: PiTrem

app/models/reaction.rb

@@ -289,6 +289,8 @@ def cleanup_array_fields
   end
 
   def auto_set_short_label
+    return if short_label.present?
+
     prefix = creator.reaction_name_prefix
     counter = creator.counters['reactions'].succ
     self.short_label = "#{creator.initials}-#{prefix}#{counter}"
@@ -299,9 +301,10 @@ def update_counter
   end
 
   def scrub
-    if temperature&.fetch('userText', nil).present?
-      self.temperature = temperature.merge('userText' => scrubber(temperature['userText']))
-    end
+    return if temperature&.fetch('userText', nil).blank?
+
+    self.temperature = temperature.merge('userText' => scrubber(temperature['userText']))
+
     # Conditions are not scrubbed: plain text may contain "<" or ">" (e.g. "pH < 7");
     # scrub_xml would strip them. Conditions are escaped at display time.
   end

spec/lib/import/import_collections_spec.rb

@@ -87,7 +87,7 @@
         expect(reaction.temperature.to_s).to eq('{"data"=>[], "userText"=>"30", "valueUnit"=>"°C"}')
         expect(reaction.status).to eq('Done')
         expect(reaction.solvent).to eq('')
-        expect(reaction.short_label).to eq('UU-R1')
+        expect(reaction.short_label).to eq('FM-R2')
         expect(reaction.role).to eq('gp')
         expect(reaction.duration).to eq('1 Day(s)')
         expect(reaction.conditions).to eq('')