Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine decay and production coupling into single symbol #156

Closed
Zeyna777 opened this issue Mar 3, 2025 · 1 comment · Fixed by #159
Closed

Combine decay and production coupling into single symbol #156

Zeyna777 opened this issue Mar 3, 2025 · 1 comment · Fixed by #159
Assignees
@redeboer
Labels
✨ Feature New feature added to the package
Milestone
0.2.3

Comments

@Zeyna777
Copy link

Zeyna777 commented Mar 3, 2025

To normalize the production couplings when performing fits with the dpd model, the production- and decay symbol within the terms of each amplitude have to be combined into a single symbol indexed with the corresponding quantum numbers.

Somewhat like this:

Image

Image
@Zeyna777 Zeyna777 self-assigned this Mar 3, 2025
@Zeyna777 Zeyna777 added the ✨ Feature New feature added to the package label Mar 3, 2025
@redeboer redeboer changed the title FIX: Combine decay and production coupling symbol into single Combine decay and production coupling into single symbol Mar 3, 2025
@redeboer
Copy link
Member

redeboer commented Mar 4, 2025

The solution lies here:

ampform-dpd/src/ampform_dpd/__init__.py

Lines 169 to 182 in 7af7d3c

h_prod = _create_coupling_symbol(
self.use_production_helicity_couplings,
resonance=R,
helicities=(λR_val, λ[k]),
interaction=chain.incoming_ls,
typ="production",
)
h_dec = _create_coupling_symbol(
self.use_decay_helicity_couplings,
resonance=R,
helicities=(λ[i], λ[j]),
interaction=chain.outgoing_ls,
typ="decay",
)

The code is not nice though and some functions need to be extracted in order to let the spaghetti code not become even longer once more options are added to the builder (here: a switch between couplings and coefficients). I'll give it a try.

@redeboer redeboer mentioned this issue Mar 5, 2025
Merged
@redeboer redeboer added this to the 0.2.3 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redeboer redeboer

Labels
✨ Feature New feature added to the package
Projects
None yet
Milestone
0.2.3
Development

Successfully merging a pull request may close this issue.

FEAT: implement use_coefficients switch ComPWA/ampform-dpd
2 participants
@redeboer @Zeyna777