Skip to content

Meta cat upd#21

Merged
mart-r merged 13 commits intomainfrom
MetaCAT_upd
Jun 4, 2025
Merged

Meta cat upd#21
mart-r merged 13 commits intomainfrom
MetaCAT_upd

Conversation

@shubham-s-agarwal
Copy link
Copy Markdown
Collaborator

@shubham-s-agarwal shubham-s-agarwal commented May 22, 2025

Improved documentation by addressing:

  • saving model by overwriting the existing one as default
  • mentioning the function that auto adjusts for variations in task and class names
  • Added note that training from scratch is not recommended

@shubham-s-agarwal
Pushing change for MetaCAT training
d7317b1 
Improved by addressing:
- saving model by overwriting the existing one as default
- mentioning the function that auto adjusts for variations in task and class names
- Added note that training from scratch is not recommended
@shubham-s-agarwal
Update meta_annotation_training.ipynb
281c75a
@shubham-s-agarwal shubham-s-agarwal self-assigned this May 22, 2025
@mart-r
Copy link
Copy Markdown
Collaborator

mart-r commented May 22, 2025

@shubham-s-agarwal perhaps you want to sync with main branch so as to avoid merge conflicts?

@mart-r
Copy link
Copy Markdown
Collaborator

mart-r commented May 23, 2025

This still has merge conflicts. Please sync / merge main into this and resolve them.

@shubham-s-agarwal
Copy link
Copy Markdown
Collaborator Author

shubham-s-agarwal commented May 23, 2025

Done!

@mart-r
Copy link
Copy Markdown
Collaborator

mart-r commented May 23, 2025 •
edited
Loading

You also want to make the workflow run on a later runner. E.g
4001e88

Though technically it's a separate issue and would better fit in a separate PR. But we've not been that pedantic on WWC.

@mart-r
Copy link
Copy Markdown
Collaborator

mart-r commented Jun 3, 2025

Made some changes:

  • Make workflow run on Ubuntu 24.04 (the 20.04 runners don't exist anymore)
  • Bump dependency versions to medcat~=1.16.0 to avoid issues
  • Allow python 3.12 on workflow, remove 3.8
  • Update spacy versions to avoid conflicts
  • Fix some issues due to pydantic update in medcat (1->2)

So now workflow runs and is successful.

@shubham-s-agarwal
Shouldn't have changed anything on your side, but do double check please.

@shubham-s-agarwal
Copy link
Copy Markdown
Collaborator Author

shubham-s-agarwal commented Jun 4, 2025

Looks good to me!
Shall I go ahead and merge?

@mart-r mart-r merged commit 3e5ec5d into main Jun 4, 2025
4 checks passed
@shubham-s-agarwal shubham-s-agarwal deleted the MetaCAT_upd branch June 4, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomolopolis tomolopolis Awaiting requested review from tomolopolis

Assignees

@shubham-s-agarwal shubham-s-agarwal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shubham-s-agarwal @mart-r @tomolopolis