Skip to content

Commit c8df93b

Browse files
committed
chore:
1 parent ba3730b commit c8df93b

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -341,8 +341,8 @@ sudo make install
341341
## 注意事项
342342

343343
#### 雷区
344-
1. 不要在任务中操纵组件,如:`submit([&br]{br.wait_tasks();});` (递归加锁问题) <br>
345-
2. 不要在回调中操纵组件,如:`set_tick_cb([&sp]{sp.suspend();});` (递归加锁问题) <br>
344+
1. 不要在任务中操纵组件,如:`submit([&br]{br.wait_tasks();});` 会阻塞线程 <br>
345+
2. 不要在回调中操纵组件,如:`set_tick_cb([&sp]{sp.suspend();});` <br>
346346
3. 不要让workbranch先于supervisor析构(空悬指针问题)。
347347

348348
#### 接口安全性

include/workspace/supervisor.h

+2-3
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,10 @@ class supervisor {
8686
* @param cb callback function
8787
*/
8888
void set_tick_cb(tick_callback_t cb) {
89-
std::lock_guard<std::mutex> lock(spv_lok);
9089
tick_cb = cb;
9190
}
9291
private:
93-
92+
// loop func
9493
void mission() {
9594
while (!stop) {
9695
try {
@@ -101,7 +100,7 @@ class supervisor {
101100
auto tknums = pbr->num_tasks();
102101
auto wknums = pbr->num_workers();
103102
// adjust
104-
if (tknums) { // block number of tasks
103+
if (tknums) {
105104
sz_t nums = std::min(wmax-wknums, tknums-wknums);
106105
for (sz_t i = 0; i < nums; ++i) {
107106
pbr->add_worker(); // quick add

0 commit comments

Comments
 (0)