Refactor Doctrine connections persistence

Author: TavoNiievez

src/Codeception/Lib/Connector/Symfony.php

@@ -6,9 +6,6 @@
 
 use InvalidArgumentException;
 use LogicException;
-use ReflectionMethod;
-use ReflectionProperty;
-use Symfony\Bundle\FrameworkBundle\Test\TestContainer;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\HttpKernelBrowser;
@@ -114,32 +111,16 @@ private function getProfiler(): ?Profiler
 
     private function persistDoctrineConnections(): void
     {
-        if (!$this->container->hasParameter('doctrine.connections')) {
+        $connections = $this->container->getParameter('doctrine.connections');
+        if (!is_array($connections)) {
             return;
         }
 
-        if ($this->container instanceof TestContainer) {
-            $method = new ReflectionMethod($this->container, 'getPublicContainer');
-            $publicContainer = $method->invoke($this->container);
-        } else {
-            $publicContainer = $this->container;
-        }
-
-        if (!is_object($publicContainer) || !method_exists($publicContainer, 'getParameterBag')) {
-            return;
-        }
-
-        $target = property_exists($publicContainer, 'parameters')
-            ? $publicContainer
-            : $publicContainer->getParameterBag();
-
-        if (!is_object($target) || !property_exists($target, 'parameters')) {
-            return;
+        /** @var array<array-key, non-empty-string> $connections */
+        foreach ($connections as $connectionId) {
+            if ($this->container->has($connectionId)) {
+                $this->persistentServices[$connectionId] = $this->container->get($connectionId);
+            }
         }
-        $prop = new ReflectionProperty($target, 'parameters');
-
-        $params = (array) $prop->getValue($target);
-        unset($params['doctrine.connections']);
-        $prop->setValue($target, $params);
     }
 }