Skip to content

Commit ce6c1af

Browse files
committed
move verify tasks to nx, run build before verify
1 parent 78c2ca4 commit ce6c1af

File tree

7 files changed

+24
-11
lines changed

7 files changed

+24
-11
lines changed

nx.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@
3737
"inputs": ["production", "^production", "babelConfig", "ci"]
3838
},
3939
"verify": {
40-
"cache": true
40+
"cache": true,
41+
"dependsOn": ["^build"]
4142
},
4243
"@nx/jest:jest": {
4344
"dependsOn": ["^build"],

packages/eslint-plugin-gamut/package.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,5 @@
2222
"access": "public"
2323
},
2424
"repository": "Codecademy/gamut.git",
25-
"scripts": {
26-
"build": "nx build eslint-plugin-gamut",
27-
"verify": "tsc --noEmit"
28-
},
2925
"types": "./dist/index.d.ts"
3026
}

packages/eslint-plugin-gamut/project.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,13 @@
1313
"parallel": false
1414
}
1515
},
16+
"verify": {
17+
"executor": "nx:run-commands",
18+
"options": {
19+
"cwd": "packages/eslint-plugin-gamut",
20+
"command": "tsc --noEmit"
21+
}
22+
},
1623
"test": {
1724
"executor": "@nx/jest:jest",
1825
"outputs": ["{workspaceRoot}/coverage/packages/eslint-plugin-gamut"],

packages/gamut-tests/package.json

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,5 @@
2828
"access": "public"
2929
},
3030
"repository": "Codecademy/gamut.git",
31-
"scripts": {
32-
"build": "nx build @codecademy/gamut-tests",
33-
"verify": "tsc --noEmit"
34-
},
3531
"types": "./dist/index.d.ts"
3632
}

packages/gamut-tests/project.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,13 @@
1818
"parallel": false
1919
}
2020
},
21+
"verify": {
22+
"executor": "nx:run-commands",
23+
"options": {
24+
"cwd": "packages/gamut-tests",
25+
"command": "tsc --noEmit"
26+
}
27+
},
2128
"test": {
2229
"executor": "@nx/jest:jest",
2330
"outputs": ["{workspaceRoot}/coverage/packages/gamut-tests"],

packages/gamut/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@
4747
"scripts": {
4848
"build": "nx build @codecademy/gamut",
4949
"build:watch": "yarn build && onchange ./src -- yarn build",
50-
"compile": "babel ./src --out-dir ./dist --extensions \".ts,.tsx\"",
51-
"verify": "tsc --noEmit"
50+
"compile": "babel ./src --out-dir ./dist --extensions \".ts,.tsx\""
5251
},
5352
"sideEffects": [
5453
"**/*.css",

packages/gamut/project.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,13 @@
1919
"parallel": false
2020
}
2121
},
22+
"verify": {
23+
"executor": "nx:run-commands",
24+
"options": {
25+
"cwd": "packages/gamut",
26+
"command": "tsc --noEmit"
27+
}
28+
},
2229
"test": {
2330
"dependsOn": ["^build"],
2431
"executor": "@nx/jest:jest",

0 commit comments

Comments
 (0)